Set listener qps and burst#4558
Open
nikola-jokic wants to merge 1 commit into
Open
Conversation
nikola-jokic
requested review from
Steve-Glass,
mumoshu,
rentziass and
toast-gear
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the ghalistener scaler’s in-cluster Kubernetes client configuration to reduce client-go throttling during high job throughput, aligning expected throughput with the listener batch size behavior discussed in #4554.
Changes:
- Set Kubernetes client-go rate limit defaults in the listener scaler to
QPS=50andBurst=100. - Reformat the “Ephemeral runner set scaled” log call (no functional change).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+62
| conf.QPS = 50 | ||
| conf.Burst = 100 |
| @@ -216,7 +219,8 @@ func (w *Scaler) HandleDesiredRunnerCount(ctx context.Context, count int) (int, | |||
| return 0, fmt.Errorf("could not patch ephemeral runner set , patch JSON: %s, error: %w", string(mergePatch), err) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the size of the batch is currently 50, and the 50 should not be a huge number for requests/s, set the QPS to 50 with burst 100 in the listener client.
Fixes #4554