Repository navigation
Remove retired SAG and Letta benchmark implementations - #386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the retired SAG v1 and Letta V1 Python implementations from the current competitor benchmark. The default matrix now has ten targets. Remove their adapters, image build registrations, Compose services and SAG database volume declaration, Dockerfiles, Letta client lock, and implementation-only test.
Reject unknown or retired target selection before artifact creation or provider access. Keep the four suite contracts and shared scoring, failure, provenance, and mutation checks. Document the previous revision for historical reproduction; dated reports remain unchanged and are not current-product comparisons. No provider-backed benchmark was run.
Validation: 45 benchmark contract tests passed, including the CLI rejection regression. Documentation, Rust/TOML format checks, diff whitespace, and Docker Compose configuration validation passed. Reverse search found no retired target references in the current runtime/configuration paths. Older dated fixture/smoke lanes remain historical scope.