fix(rbac): drop unused write permissions on nodes from clusterrole - #780
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
The clusterrole grants create, update and delete on nodes along with every other watched resource, but the codebase only ever lists nodes to build cluster info, never writes to them. Split nodes into their own rule with just get, list and watch. Fixes accuknox#753 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
The clusterrole grants create, update and delete on nodes along with every other watched resource, but the codebase only ever lists nodes to build cluster info, never writes to them. This splits nodes into their own rule with just get, list and watch.
Fixes #753
Does this PR introduce a breaking change?
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Verified via YAML syntax check on the updated manifests, and by confirming nodes are only ever listed (never created, updated, or deleted) anywhere in the codebase.
Additional information for reviewer? :
None.
Checklist:
<type>(<scope>): <subject>