-
Notifications
You must be signed in to change notification settings - Fork 0
feat: share local dev infrastructure across worktrees #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
08d0f27
docs: design shared worktree dev infrastructure
absolutepraya 83b7e92
docs: tighten shared dev infra design
absolutepraya 07f6953
docs: plan shared local dev infrastructure
absolutepraya 0120285
test: define shared dev infrastructure contract
absolutepraya 00c408d
test: define shared dev infrastructure contract
absolutepraya 5e358db
test: define shared dev infrastructure contract
absolutepraya 0911b8a
feat: namespace Meilisearch indexes
absolutepraya 7a4d3aa
feat: namespace Meilisearch indexes
absolutepraya 406d489
feat: namespace Meilisearch indexes
absolutepraya 79aef9a
feat: namespace Meilisearch indexes
absolutepraya 78f4927
feat: namespace Meilisearch indexes
absolutepraya a1c4f84
feat: add shared local dev infrastructure
absolutepraya 2b933e8
feat: reuse dev infrastructure across worktrees
absolutepraya d21f5e4
feat: reuse dev infrastructure across worktrees
absolutepraya d8febfb
feat: reuse dev infrastructure across worktrees
absolutepraya 8cf4c4d
feat: reuse dev infrastructure across worktrees
absolutepraya d760a99
test: invoke shared dev helper through Bash
absolutepraya 5de8c73
fix: invoke shared dev helper through Bash
absolutepraya df53805
test: validate shared dev helper syntax
absolutepraya 3439f41
docs: explain shared worktree dev infrastructure
absolutepraya 099c957
docs: explain shared worktree dev infrastructure
absolutepraya ee063a5
chore: placeholder
absolutepraya 410596a
chore: remove accidental placeholder
absolutepraya fc0afe1
chore: sync assistant docs
absolutepraya 1067ff7
chore: remove sync marker
absolutepraya 3a7f267
docs: sync assistant local-dev guidance
absolutepraya 7e87b3c
docs: sync assistant local-dev guidance
absolutepraya cf1a8a9
fix: polish shared worktree setup
absolutepraya 7e79463
fix: avoid unnecessary dev readiness delay
absolutepraya 51f70ce
noop
absolutepraya 9bdac37
chore: remove accidental scratch file
absolutepraya 3ed2295
noop2
absolutepraya 0551eb9
chore: remove accidental scratch file
absolutepraya cb9c0a4
noop3
absolutepraya 7096480
chore: remove accidental scratch file
absolutepraya 72bf8a4
noop
absolutepraya 60c30ca
chore: remove accidental scratch file
absolutepraya f3b7031
merge: reconcile shared dev infra with Marka main
absolutepraya d63b994
test: cover Meilisearch-safe worktree slugs
absolutepraya 9741eb7
fix: keep worktree index prefixes Meilisearch-safe
absolutepraya 082d885
test: isolate worktrees from inherited service endpoints
absolutepraya a85a7e7
fix: pin worktrees to shared dev services
absolutepraya e0b79dd
test: run Meilisearch namespace checks in CI
absolutepraya bbad056
merge: update shared dev infra branch from main
absolutepraya 597fed2
fix: harden shared dev workflow checks
absolutepraya dc27900
fix: pin shared dev service selection
absolutepraya 5b72405
test: guard shared service environment isolation
absolutepraya 214b633
docs: require namespace for manual dev starts
absolutepraya 5a9a1d7
docs: reconcile shared dev guide with main
absolutepraya 9b73f9f
test: validate each dev Bash script separately
absolutepraya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| name: Dev Workflow Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "start-dev.sh" | ||
| - "stop-dev.sh" | ||
| - "scripts/setup-worktree.sh" | ||
| - "scripts/dev-infra.sh" | ||
| - "scripts/dev-infra.test.sh" | ||
| - "packages/plugins/lib/meiliIndexName.ts" | ||
| - "packages/plugins/lib/meiliIndexName.test.ts" | ||
| - "packages/plugins/search-meilisearch/**" | ||
| - "packages/plugins/vectorstore-meilisearch/**" | ||
| - "package.json" | ||
| - ".github/workflows/dev-workflow-tests.yml" | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "start-dev.sh" | ||
| - "stop-dev.sh" | ||
| - "scripts/setup-worktree.sh" | ||
| - "scripts/dev-infra.sh" | ||
| - "scripts/dev-infra.test.sh" | ||
| - "packages/plugins/lib/meiliIndexName.ts" | ||
| - "packages/plugins/lib/meiliIndexName.test.ts" | ||
| - "packages/plugins/search-meilisearch/**" | ||
| - "packages/plugins/vectorstore-meilisearch/**" | ||
| - "package.json" | ||
| - ".github/workflows/dev-workflow-tests.yml" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| shared-dev-infra: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup | ||
| uses: ./tooling/github/setup | ||
|
|
||
| - name: Check Bash syntax | ||
| run: | | ||
| for script in start-dev.sh stop-dev.sh scripts/setup-worktree.sh scripts/dev-infra.sh scripts/dev-infra.test.sh; do | ||
| bash -n "$script" | ||
| done | ||
|
|
||
| - name: Run shared dev infrastructure tests | ||
| run: bash scripts/dev-infra.test.sh | ||
|
|
||
| - name: Run Meilisearch namespace tests | ||
| run: pnpm --filter @karakeep/plugins test --run | ||
|
|
||
| - name: Typecheck plugins | ||
| run: pnpm --filter @karakeep/plugins typecheck | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.