Skip to content

Send echo=true connection param by default (RTC1a) #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tyagiquamar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Send echo=true connection param by default (RTC1a) #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/common/lib/transport/connectionmanager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ export class TransportParams {
if (options.clientId !== undefined) {
params.clientId = options.clientId;
}
if (options.echoMessages === false) {
params.echo = 'false';
}
params.echo = options.echoMessages === false ? 'false' : 'true';
if (this.format !== undefined) {
params.format = this.format;
}
Expand Down
10 changes: 0 additions & 10 deletions test/uts/deviations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,6 @@ Tests marked with `if (!process.env.RUN_DEVIATIONS) this.skip()` are skipped by

These tests assert spec behavior but are skipped by default because they are known to fail. Run with `RUN_DEVIATIONS=1` to execute them.

### realtime_client: RTC1a - echoMessages default does not send echo=true

**Spec (RTC1a)**: The `echoMessages` option (default true) should be sent as `echo=true` query parameter.

**ably-js behavior**: ably-js only sends `echo=false` when `echoMessages` is explicitly false. When `echoMessages` is true (default), no `echo` parameter is sent — the server defaults to echoing.

**Test**: `RTC1a - echoMessages default sends echo=true` — asserts `echo=true` per spec.

---

### channel_detach: RTL5k - ATTACHED while detached does not send DETACH

**Spec (RTL5k)**: If the channel receives an ATTACHED message while in the DETACHED state, it should send a new DETACH message.
Expand Down
1 change: 0 additions & 1 deletion test/uts/realtime/unit/client/realtime_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ describe('uts/realtime/unit/client/realtime_client', function () {
*/
// UTS: realtime/unit/RTC1a/echo-messages-option-0
it('RTC1a - echoMessages default sends echo=true', async function () {
if (!process.env.RUN_DEVIATIONS) this.skip(); // ably-js omits echo param when true
let echoParam: string | null = null;
const mock = new MockWebSocket({
onConnectionAttempt: (conn) => {
Expand Down