fix: prevent first-owner write loss in in-memory stores - #1194
Open
anxkhn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
anxkhn
force-pushed
the
fix/inmemory-owner-dict-race
branch
from
August 20, 2026 20:48
a09e2ad to
1e833b7
Compare
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/tasks/inmemory_task_store.py | 97.14% | 97.06% | 🔴 -0.08% |
| Total | 92.97% | 92.97% | 🔴 -0.01% |
Generated by coverage-comment.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_InMemoryTaskStoreImpl.saveandInMemoryPushNotificationConfigStore.set_infocreated owner buckets before acquiring their existingRLock. Two threads could both observe a missing owner, create separate buckets, and overwrite the bucket containing the first completed write.This moves owner-bucket creation inside the lock with
setdefaultin both stores. Threaded regression tests cover concurrent first writes and confirm that both records remain available through the public retrieval methods.Testing
uv run pytest tests/server/tasks/test_inmemory_task_store.py tests/server/tasks/test_inmemory_push_notifications.py -qResult: 40 passed.