Feature/some refactorings#8
Open
n0900 wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamentally refactor
ObjectBackedfrom interface with generics to abstract class without. In particular becauseObjectBackeddoes no longer carry a generic type we should be able to use it in classes that need more than one serialization path (json and cbor for example) although this is future workThe previous generic (
V) fixing the type of the backing object is not necessary.decodeis renamed togetElementand originalgetElementremoved. IntegratedObjectBackedValidatedintoObjectBackedbut the validate function has default implementation that does nothing.The ultimate goal is that the helper classes such as
JsonBackedObjectare easy to implement and most logic lies in the abstract class extension functions (in ObjectBackedProperty.kt)