Skip to content

Fix uint64_t overflow in SectionBMC bounds check #9962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsoe wants to merge 1 commit into from
+3 −5
Closed

Fix uint64_t overflow in SectionBMC bounds check #9962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/runtime_src/tools/xclbinutil/SectionBMC.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,9 @@ SectionBMC::copyBufferUpdateMetadata(const char* _pOrigDataSection,
% pHdr->m_version
% pHdr->m_md5value);

uint64_t expectedSize = pHdr->m_offset + pHdr->m_size;

// Check to see if array size
if (expectedSize > _origSectionSize) {
auto errMsg = boost::format("ERROR: bmc section size (0x%lx) exceeds the given segment size (0x%lx).") % expectedSize % _origSectionSize;
// Guard against uint64_t overflow before comparing against section size
if (pHdr->m_size > _origSectionSize || pHdr->m_offset > _origSectionSize - pHdr->m_size) {
auto errMsg = boost::format("ERROR: bmc m_offset (0x%lx) + m_size (0x%lx) exceeds the given segment size (0x%lx).") % pHdr->m_offset % pHdr->m_size % _origSectionSize;
throw std::runtime_error(errMsg.str());
}

Expand Down
Loading