Repository navigation
Conversation
…ction -fixed the code style according to PEP8
There was a problem hiding this comment.
I believe this should go in the 0.23 section
There was a problem hiding this comment.
Ok, I will fix CHANGELOG.md
I have a question. Although I didn't change function hermite_multidimensional in _hermite_multidimensional.py, it compatible with a list cutoff by design. Should I change the documentation of this function?
Co-authored-by: Filippo Miatto <ziofil@users.noreply.github.com>
Co-authored-by: Filippo Miatto <ziofil@users.noreply.github.com>
|
@ziofil, can I do something to help this change appear in the next release? |
|
@svan5003 yes, let's merge this PR :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1922 1941 +19
=========================================
+ Hits 1922 1941 +19
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@ziofil thanks for the feedback! I've just run the suggested command locally and committed changes. Now, it must be fine |
|
@ziofil could you please run the checks again? |
|
Hi @ziofil, is this pull request still relevant? Please let me know if any further changes are needed |
Context:
'cutoff' argument for the 'density_matrix(mu, cov, post_select, normalize, cutoff, hbar)' function from 'fock_tensors.py' is the same for all modes
Description of the Change:
Added support of the 'list' type of 'cutoff' argument for the 'density_matrix(mu, cov, post_select, normalize, cutoff, hbar)' function from 'fock_tensors.py'. It enables to perform larger simulations.
Example: 4 bosonic modes
Hilbert space dimensions 20 for each mode => ~380 GB of RAM for a density matrix.
Hilbert space dimensions 20 for 2 main and 3 for auxiliary modes => 200 MB of RAM for a density matrix.
Benefits:
Enables users to choose different Hilbert space dimensions for different modes of a density matrix. It can be helpful for simulations with a large number of modes.
Possible Drawbacks:
None
Related GitHub Issues:
None