Repository navigation
File: Keep the block's file when a Replace upload fails - #87094
Draft
SainathPoojary wants to merge 2 commits into
Draft
SainathPoojary wants to merge 2 commits into
SainathPoojary wants to merge 2 commits into
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #87093
When a Replace upload fails, the File block now keeps its current file. Reset still removes it.
Why?
Failed Replace upload removes the file and the block goes back to the empty placeholder. Image, Audio and Video already keep their media after a failed upload (#86290), File block has similar issue.
How?
blobattribute and the temporary URL. It used to clearhref(rejected file) or every file attribute (server error).onResetFile(). It clears the file as before.Testing Instructions
.exe. An error notice appears and the file stays./wp/v2/media, or use a local override that returns a 500. Then choose Replace → Upload and pick a normal file. An error notice appears and the file stays..exefile on it. The placeholder stays and the spinner stops.Screenshots or screencast
Before
2026-11-19.18-00-06.mp4
After:
2026-11-19.17-53-15.mp4
Use of AI Tools
Claude Code (Claude Opus 5.5) helped with the code changes. Review and testing the changes was done by me