Repository navigation
Playlist: Skip hidden tracks when building the track list #87070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashjawale
wants to merge
9
commits into
WordPress:trunk
Choose a base branch
from
yashjawale:fix/playlist-hidden-blocks
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f6b7ba0
fix: prevent hidden tracks from being played
yashjawale a0fac16
Merge branch 'trunk' into fix/playlist-hidden-blocks
yashjawale 65b2367
fix: skip tracks hidden on the current screen size when the playlist
yashjawale d62469a
test: add e2e test for skipping hidden tracks in the playlist
yashjawale 7b4507f
Merge branch 'trunk' into fix/playlist-hidden-blocks
yashjawale 106fd26
fix: don't load a playlist track when none are visible
yashjawale e883ae4
fix: keep playlist tracks playable when the tracklist is hidden
yashjawale e786ccb
Merge branch 'trunk' into fix/playlist-hidden-blocks
yashjawale 16af5e5
Merge branch 'trunk' into fix/playlist-hidden-blocks
yashjawale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yashjawale, This won't work as expected when it's being hidden only on a single viewport or combination. The attributes we would be getting would be something like this. So all of this needs to be consider.
Also,
$inner_block->parsed_block['attrs']['metadata']['blockVisibility'], instead we are having$track_attributes, let's use that for the check instead of getting it again from the innerblock.Screen.Recording.2026-11-19.at.2.58.46.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update the test case to include all this scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated to use
$track_attributesand now handling partially hidden blocks in viewjs script.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also included additional test cases for different scenarios.