Repository navigation
Conversation
The time zone detail was in a tooltip on a non-focusable element, so only mouse users could reach it. Make the abbreviation a popover trigger from @wordpress/ui that opens on hover or activation, so keyboard, touch, and screen reader users can reach it too. The popover portals into the compat overlay slot, so it also shows above @wordpress/ui overlays.
🤖 PR meta 🤖📦 Bundle sizeSize Change: +6.59 kB (+0.08%) Total Size: 8.69 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. should select synced pattern in
|
The time zone abbreviation and its infotip only show when the site time zone differs from the user's, which the existing stories never set up.
Also render the time zone story in its own iframe on the docs page, so its site time zone setting does not apply to the other stories there, and update the changelog entry.
It landed separately in #86826.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the tooltip that shows the full site time zone in
TimePickerwith an infotip: the time zone abbreviation becomes a button that opens a@wordpress/uiPopoveron hover, click, tap, or Enter.Why?
The tooltip was attached to a
<div>that cannot receive focus, so only mouse users could read the full time zone. The@wordpress/uiusage guidelines recommend a popover for this kind of supplementary information, so that keyboard, touch, and screen reader users can reach it.This is also one of the changes that move
@wordpress/componentsinternals off its own tooltip, which portals tobodywith a fixed z-index and so appears behind@wordpress/uioverlays. The popover renders in the compat overlay slot, where it stacks above both.How?
The abbreviation itself is the trigger, rather than a separate help icon as in the infotip guidelines, because its dotted underline already signals that there is more to read and the time row has no room for another control. Its accessible name, "Timezone: AST", gives the abbreviation context for screen reader users, and the popover keeps its default hover delays rather than the old tooltip's timing.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
@wordpress/uiDialog