Skip to content

Components: Increase small Button font size - #79993

Open
simison wants to merge 11 commits into
trunkfrom
update/components-button-wpds-tokens
Open

simison wants to merge 11 commits into
trunkfrom
update/components-button-wpds-tokens

Conversation

@simison

@simison simison commented Jul 8, 2026 •

Copy link
Copy Markdown
Member

Part of #76135.

What?

Increase the font size of small @wordpress/components Buttons from 11px to 13px.

Why?

This matches the label size of the small @wordpress/ui Button.

How?

Use --wpds-typography-font-size-md for size="small". The stylesheet still gives small Buttons a 24px height and a 22px line height. The larger labels need more room in narrow containers.

Related Button token work

Earlier token updates landed in #78646 and #79278. The color changes landed in #86681, #86683, and #86684. See the scope discussion.

Testing Instructions

  1. Run npm run storybook:e2e:dev and open the Button variant matrix.
  2. Compare the small row with the compact and default rows. The small labels should match their 13px font size.
  3. Open the Icon matrix and set children to Code is poetry in Controls. Check that the small icon-and-text variants, including the link, still measure 24px high.
  4. Open the Text Overflow story and select the small size. Inspect the same label in the unconstrained and fixed-width examples.

Testing Instructions for Keyboard

In the story canvas, Tab through the small variants. Check that each Button shows its focus outline.

Screenshots or screencast

All rows use size="small". The two trunk columns use 3b5195cf76e. The PR column uses 27787248a35. The dashed outline marks the available width in the narrow examples. The WordPress UI column uses a brand minimal Button for link-style actions and IconButton for the icon-only row.

Small Button use case Before · @wordpress/components on trunk After · @wordpress/components in this PR @wordpress/ui on trunk
Default text Default small Button Default small Button Default small Button
Primary text Primary small Button Primary small Button Primary small Button
Secondary text Secondary small Button Secondary small Button Secondary small Button
Tertiary text Tertiary small Button Tertiary small Button Tertiary small Button
Link-style action Link-style small action Link-style small action Minimal small Button
Default with icon Default small Button with a leading icon Default small Button with a leading icon Default small Button with a leading icon
Primary with leading icon Primary small Button with a leading icon Primary small Button with a leading icon Primary small Button with a leading icon
Secondary with trailing icon Secondary small Button with a trailing icon Secondary small Button with a trailing icon Secondary small Button with a trailing icon
Tertiary with icon Tertiary small Button with a leading icon Tertiary small Button with a leading icon Tertiary small Button with a leading icon
Link-style action with icon Link-style small action with a leading icon Link-style small action with a leading icon Minimal small Button with a leading icon
Icon only 24px square small icon button 24px square small icon button 24px square small icon button
Busy / loading Small busy Button with a striped background Small busy Button with a striped background Small loading Button with a spinner
Primary in 98px Primary Button fits on one line Primary Button extends past the container on one line Primary Button wraps to two lines and grows to 42px
Default in 98px Default Button fits on one line Default Button wraps to two lines and text extends past its 24px box Default Button wraps to two lines and grows to 42px
Link-style action in 108px Link-style action fits on one line Link-style action wraps to two lines and text extends past its 24px box Minimal Button wraps to two lines and grows to 42px
Unbroken label in 92px Unbroken label exceeds the container width Larger unbroken label exceeds the container width Unbroken label wraps to three lines and the Button grows to 62px
Measured line height, icon sizing, and wrapping
  • Small @wordpress/components Buttons use a 22px line height and a fixed 24px height before and after. Small @wordpress/ui Buttons use a 20px line height and a 24px minimum height.
  • The same SVG renders at 24 × 24px in all three columns. Beside text, @wordpress/ui reserves 16px of inline space for that icon via negative margins. The legacy Button reserves all 24px, plus its own gap and padding. The icon-only button measures 24 × 24px in all three columns.
  • “Reset spacing” needs 95px for a single line before and 107px after. At 98px, the primary legacy Button overflows horizontally because it keeps the label on one line. The default legacy Button wraps and the label extends beyond its 24px box. The link-style label behaves the same way at 108px. The corresponding @wordpress/ui examples grow to 42px for two lines and 62px for the three-line unbroken label.
  • The link-style underline offset is relative to the font size. It increases from 2.2px to 2.6px with the larger label.

I also checked the Reset buttons in the BoxControl and RangeControl stories at the 248px WordPress Sidebar setting. Both still fit beside their neighboring controls.

Gutenberg screens

Captured in Chromium at 1280 × 900 on the same local WordPress site. Before uses current trunk bd0c79f54fd. After uses this PR at 27787248a35.

Use case Before · trunk After · this PR
Pages list · Edit Trunk showing the inline Edit action in the Site Editor’s Pages list This PR showing the inline Edit action in the Site Editor’s Pages list
Navigation block · Back Trunk showing the focused Back button in the Navigation block’s Add block popover This PR showing the focused Back button in the Navigation block’s Add block popover
Styles palette · Done Trunk showing the Done button next to Add color and Color options in the custom palette This PR showing the Done button next to Add color and Color options in the custom palette

Each label stayed on one line and fit in its button. The height measured 24px and the line height measured 22px in both captures. Edit, Back, and Done became 3.3px, 5.0px, and 4.5px wider, respectively. The Back icon measured 24 × 24px in both captures.

How to reproduce these screens
  • Pages list. Open Pages in the Site Editor and hover a page to reveal its inline Edit action.
  • Navigation block. In the post editor, select a Navigation block with a saved menu. Use the block appender, then choose Add block. Check Back in the popover.
  • Styles palette. Open the Site Editor’s Styles sidebar and select Colors → Edit palette. Add a custom color to reveal Done beside the palette controls.

Use of AI Tools

Codex narrowed the implementation, ran the verification, captured the screenshots, and drafted this update.

@simison
simison requested review from a team and ajitbohra as code owners July 8, 2026 10:12
@simison simison added [Package] Components /packages/components [Feature] Component System WordPress component system Design System Issues related to the system of combining components according to best practices. labels Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: [Package] Components, [Feature] Component System, Design System.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Comment on lines +12 to +13
// Legacy default height (36px) has no exact WPDS size token match.
--wp-components-button-height: 36px;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's an alternative solution 🤔

@github-actions

github-actions Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Size Change: +435 B (+0.01%)

Total Size: 7.75 MB

📦 View Changed
Filename Size Change
build/styles/components/style-rtl.css 18.2 kB +112 B (+0.62%)
build/styles/components/style-rtl.min.css 15.1 kB +103 B (+0.69%)
build/styles/components/style.css 18.2 kB +115 B (+0.63%)
build/styles/components/style.min.css 15.1 kB +105 B (+0.7%)

compressed-size-action

@github-actions

github-actions Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Flaky tests detected in b87b609.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29116506316
📝 Reported issues:

@simison

This comment was marked as outdated.

@ciampo ciampo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm torn on whether we should continue to use the SASS variables or switch to WPDS tokens directly. if the goal is true @wordpress/ui alignment, we should migrate Button internals toward WPDS tokens directly. If the goal is legacy compatibility, keep component aliases or use local Button variables that bridge both, eg

--wp-components-button-background-color: var(
  --wp-components-color-accent,
  var(--wpds-color-background-interactive-brand-strong)
);

That gives a migration path without dropping existing customization hooks too abruptly.

Re. background: transparent, I guess that we should generally map to WPDS weak background tokens (instead of raw transparent) when they represent a button tone/variant.

We should also be careful when replacing background: none with a color token. background: none resets images too, which matters for busy/loading styles.

Here's a potential mapping
components primary
-> ui brand solid
bg: --wpds-color-background-interactive-brand-strong
bg active: --wpds-color-background-interactive-brand-strong-active
fg: --wpds-color-foreground-interactive-brand-strong

components secondary
-> ui brand outline
bg: --wpds-color-background-interactive-brand-weak        // #0000
bg active: --wpds-color-background-interactive-brand-weak-active
bg disabled: --wpds-color-background-interactive-brand-weak-disabled
border: --wpds-color-stroke-interactive-brand
fg: --wpds-color-foreground-interactive-brand

components tertiary
-> ui brand minimal
bg: --wpds-color-background-interactive-brand-weak        // #0000
bg active: --wpds-color-background-interactive-brand-weak-active
bg disabled: --wpds-color-background-interactive-brand-weak-disabled
fg: --wpds-color-foreground-interactive-brand

destructive secondary/tertiary
-> error outline/minimal equivalent
bg: --wpds-color-background-interactive-error-weak        // #0000
bg active: --wpds-color-background-interactive-error-weak-active
fg: --wpds-color-foreground-interactive-error
border: --wpds-color-stroke-interactive-error for outline-ish secondary

This is a change with a potential large visual impact, probably better to land it after the next Gutenberg release (which means this change will be included in WP 7.2, giving us ample time to test and make adjustments if needed)

Also cc @t-hamano as some the folks with the keenest eye on Button.

Comment on lines +71 to +73
// TODO: Prepare for theming (https://github.com/WordPress/gutenberg/pull/45466/files#r1030872724)
color: rgba($white, 0.4);
color: var(--wpds-color-foreground-interactive-brand-strong-disabled);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potentially substantial difference. More in general, would you mind updating a full matrix of the button variants, like done in #78646 ?

We have a specific Storybook example used for ad-hoc e2e viz reg that you can visit by running npm run storybook:e2e:dev

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip about strokybook:e2e! Didn't know we had more examples to test with there.

I'm assuming some visual changes are ok considering what we just did with Notice.

Primary+disabled button:

Components Button in PR:
image

Components Button in trunk (looks better):
image

UI Button:
image

So I think we should change the background and text colour in tandem, at least for the disabled state, to avoid some kind of mixed style between the two that doesn't look that great.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although I believe this warrants a broader conversation (to make sure we potentially address button styles on the php side) and the blessing of @WordPress/gutenberg-design

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up. What needs a decision here? Is it the disabled state? If yes then I agree trunk looks better, gray on blue is barely legible (even though it doesn't have to be on a disabled button).

Noting that there was a previous attempt to move disabled buttons to look substantially less prominent in #70674, which was reverted specifically because we wanted to move towards a more considered token-based system. In that range, does this move us in the right direction? If it's mostly the disabled states, let me know and I'll test more in-depth those styles.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen, in the UI-Button disabled state looks like this:

image

Can we make the components-Button look the same, or is it better to keep it as-is today (image below) and migrate to the new disabled style by swapping out components around Gutenberg one-by-one?

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarity. I feel like this is moving in the right direction, on all counts, and is a good argument for why we made the origiginal change. It's exactly what we said we'd do: do it systematically, with tokens. Kudos.

Can we make the components-Button look the same, or is it better to keep it as-is today (image below) and migrate to the new disabled style by swapping out components around Gutenberg one-by-one?

That's a good question. In principle that would be ideal since they are meant to look the same. But perhaps it's okay for this to be a slow transition with the old still keeping the legacy behavior? How do you feel about it?

@ciampo ciampo Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did mention that, ideally, we would minimize the visual difference between @wordpress/components and @wordpress/ui componentry to ensure a better transition.

IMO, we should prioritize refactoring the styles in @wordpress/components to follow the new look from @wordpress/ui, since it will allow us to mix-and-match the two components (legacy and new version) without too many inconsistencies as we progressively refactor the repo (and as third party devs may continue to use the legacy version)

@simison
simison force-pushed the update/components-button-wpds-tokens branch from f9a939d to b87b609 Compare July 10, 2026 18:59
@simison

simison commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

I updated this PR to touch only font size, border width, spacing and things like that; I'm moving all the colours-related token swapping to happen at once in the follow-up PR #79994

I'll update PR description with screenshots.

Comment thread packages/components/CHANGELOG.md Resolved
@simison
simison force-pushed the update/components-button-wpds-tokens branch from e8becb6 to e5a84a5 Compare July 15, 2026 07:28
Comment on lines 296 to 297
// 22px has no exact WPDS line-height token match (sm is 20px, md is 24px).
line-height: 22px;

@simison simison Jul 15, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI uses --wpds-typography-line-height-sm (20px) for all sizes, including small.

UI small = 24px tall, 13px font (font-size-md), 20px line-height, 0 vertical padding.

Components small = 24px tall, 11px font (font-size-xs), 22px line-height, 0 vertical padding.

Both end up 24px tall.

@simison simison Jul 15, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...separate question if we should align the font sizes for the small variant. Could be a good follow-up or done already here.

Default and compact use already the same font size.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outer size matches, although typography, internal spacing and "growth" behaviour are different.

I feel like the line height shouldn't be what guarantees the minimum clickable areas (24px), and therefore I prefer the wordpress/ui approach that uses min-height. Moreover, I believe that changing line-height here won't change the clickable box.

Still, I believe we could align font-size and line height here (ie. use font-size-md and line-height-sm) , I guess we could do it in this PR?

We will need to update the matrix screenshots, since small buttons will grow wider (not taller)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, I believe we could align font-size and line height here (ie. use font-size-md and line-height-sm) , I guess we could do it in this PR?

Let's do it. 👍 It's unavoidable anyway if we want to be able to mix components and have things look consistent.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

We will need to update the matrix screenshots, since small buttons will grow wider (not taller)

There was no small (nor compact) variants in the e2e matrix.

I added them locally and here's comparison, but snapshots wouldn't need updating:

Before
Screenshot 2026-07-16 at 15 55 45

After
Screenshot 2026-07-16 at 15 55 28

UI Button matrix with same additions:

image

@simison simison Jul 16, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm link button in small format now inherits wrong padding, need to fix that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Let me know once you've fixed that and I'll take another look

@simison simison Jul 17, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super pretty but simply avoiding resetting the padding to 0: dc954ec

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can see some regressions with small link buttons height:

Excluding .is-link from both height and padding fixes the horizontal padding, but it makes the small link target depend on its content. With the current cascade, a text-only small link is 20px tall, an icon-only one is 24px, and an icon-and-text one is 36px because the later .has-icon rule restores 6px block padding around the 24px icon. Trunk kept all three at 24px. Could we guarantee the 24px small control height for every variant and special-case only the link padding? The small link-and-icon case also needs to avoid reacquiring that later block padding.

@simison
simison force-pushed the update/components-button-wpds-tokens branch from 5844afe to 5872476 Compare July 15, 2026 08:11
@simison

simison commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

This is a change with a potential large visual impact, probably better to land it after the next Gutenberg release (which means this change will be included in WP 7.2, giving us ample time to test and make adjustments if needed)

@ciampo, agreed on this — which exact GB version is safe for Button changes?

@ciampo

ciampo commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This is a change with a potential large visual impact, probably better to land it after the next Gutenberg release (which means this change will be included in WP 7.2, giving us ample time to test and make adjustments if needed)

@ciampo, agreed on this — which exact GB version is safe for Button changes?

Probably 23.7? (@t-hamano can confirm)

@t-hamano

Copy link
Copy Markdown
Contributor

This is a change with a potential large visual impact, probably better to land it after the next Gutenberg release (which means this change will be included in WP 7.2, giving us ample time to test and make adjustments if needed)

@ciampo, agreed on this — which exact GB version is safe for Button changes?

Probably 23.7? (@t-hamano can confirm)

This PR will not be backported to WP 7.1, correct? If so, there is nothing to do. Merging this PR now will release it as part of GB 23.7.

Comment on lines 296 to 297
// 22px has no exact WPDS line-height token match (sm is 20px, md is 24px).
line-height: 22px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outer size matches, although typography, internal spacing and "growth" behaviour are different.

I feel like the line height shouldn't be what guarantees the minimum clickable areas (24px), and therefore I prefer the wordpress/ui approach that uses min-height. Moreover, I believe that changing line-height here won't change the clickable box.

Still, I believe we could align font-size and line height here (ie. use font-size-md and line-height-sm) , I guess we could do it in this PR?

We will need to update the matrix screenshots, since small buttons will grow wider (not taller)

@simison
simison force-pushed the update/components-button-wpds-tokens branch from 5872476 to 4f195ec Compare July 16, 2026 12:24
@simison
simison force-pushed the update/components-button-wpds-tokens branch 2 times, most recently from 037c139 to dc954ec Compare July 17, 2026 16:46
@ciampo

ciampo commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Now that 7.1 shipped, should we resume work and aim to ship this soon into the 7.2 dev cycle?

Noting that, in the meantime, we've unified focus rings already

@ciampo

ciampo commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Noting that we've progressively shipped changes to components/Button, which is not, at least in terms of colors, a lot more aligned with ui/Button. This PR would still be carrying unmerged changes, especially around sizes / spacing / font-size.

As for other open PRs (such as #85960), the question becomes: is the current level of "consistency" between buttons enough, or do we need to go further? Which changes are worth being applied, and which changes are not worth the potential regressions for consumers?

My gut instinct tells me that we may want to adapt the font size, and otherwise drop the rest. Let's discuss this together

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: -2 B (0%)

Total Size: 8.68 MB

📦 View Changed
Filename Size Change
build/styles/components/style-rtl.css 18.3 kB +2 B (+0.01%)
build/styles/components/style-rtl.min.css 15.4 kB -3 B (-0.02%)
build/styles/components/style.css 18.4 kB +2 B (+0.01%)
build/styles/components/style.min.css 15.4 kB -3 B (-0.02%)

54f810b Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 51afcb8 trunk % Change
timeToFirstByte 55.8 ms +5.91% -2.42% 55.65 ms +9.52% -3.86% 0.27%
largestContentfulPaint 92 ms +2.17% -8.7% 88 ms +9.09% -4.55% 4.55%
lcpMinusTtfb 32.65 ms +13.78% -10.11% 31.9 ms +17.24% -10.97% 2.35%
wpBeforeTemplate 29.29 ms +9.73% -1.33% 29.55 ms +8.19% -2.98% -0.88%
wpTemplate 22.38 ms +3.71% -3.35% 21.94 ms +4.06% -2.51% 2.01%
wpTotal 52.02 ms +5.86% -2.56% 51.69 ms +10.41% -3.4% 0.64%
wpMemoryUsage 7.75 MB +0% -0% 7.71 MB +0% -0% 0.45%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 51afcb8 trunk % Change
timeToFirstByte 47.15 ms +4.67% -2.55% 45.5 ms +5.71% -1.21% 3.63%
largestContentfulPaint 84 ms +2.38% -4.76% 80 ms +5% -0% 5%
lcpMinusTtfb 35.7 ms +6.58% -4.48% 34.85 ms +1.58% -2.15% 2.44%
wpBeforeTemplate 26.64 ms +4.99% -2.33% 26.17 ms +4.7% -1.72% 1.8%
wpTemplate 16.83 ms +4.52% -5.17% 16.2 ms +5.19% -1.6% 3.89%
wpTotal 43.6 ms +5.67% -1.61% 42.35 ms +5.45% -1.37% 2.95%
wpMemoryUsage 6.44 MB +0% -0% 6.40 MB +0% -0% 0.56%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 51afcb8 trunk % Change
mediaProcessingJpeg 403.52 ms +0.8% -0.28% 402.12 ms +0.53% -0.45% 0.35%
mediaProcessingAvif 6147.53 ms +0.28% -0.77% 6142.89 ms +0.48% -0.18% 0.08%
mediaProcessingJpegToAvif 4218.1 ms +0.83% -0.19% 4252.63 ms +0.11% -0.62% -0.81%

media-upload

Metric 51afcb8 trunk % Change
jpegUploadProcessing 2001.05 ms +1.31% -24.24% 1525.91 ms +2.62% -1.86% 31.14%
pngUploadProcessing 273.09 ms +1.33% -0.59% 280.43 ms +2.2% -2.68% -2.62%
largeJpegUploadProcessing 1749.42 ms +13.86% -14.2% 1978.93 ms +1% -23.79% -11.6%
multipleImageUploadProcessing 2069 ms +4.01% -4.73% 2092.68 ms +1.01% -2.12% -1.13%

post-editor

Metric 51afcb8 trunk % Change
serverResponse 318.34 ms +7.48% -7.11% 330.62 ms +5.72% -8.89% -3.71%
firstPaint 365.59 ms +8.92% -13.78% 340.06 ms +10.04% -6.7% 7.51%
domContentLoaded 659.05 ms +8.5% -1.79% 668.1 ms +1.24% -0.6% -1.35%
loaded 659.95 ms +8.5% -1.79% 669.04 ms +1.23% -0.59% -1.36%
firstContentfulPaint 376.93 ms +11.64% -1.72% 381.96 ms +2.46% -2.03% -1.32%
firstBlock 1759.96 ms +3.88% -2.5% 1770.45 ms +1.18% -0.66% -0.59%
type 15.74 ms +5.78% -6.61% 16.37 ms +6.17% -6.17% -3.85%
typeWithoutInspector 15.59 ms +4.62% -8.15% 15.88 ms +6.23% -11.59% -1.83%
typeWithTopToolbar 20.24 ms +3.11% -3.36% 19.79 ms +3.18% -4.95% 2.27%
typeContainer 6.92 ms +9.54% -10.84% 6.91 ms +5.21% -12.74% 0.14%
focus 96.9 ms +6.22% -4.06% 95.89 ms +3.66% -2.85% 1.05%
firstFocus 222.58 ms +0% -0% 217.51 ms +0% -0% 2.33%
selectAll 312.54 ms +0.5% -0% 325.83 ms +2.61% -3.64% -4.08%
undo 24.96 ms +6.05% -2.96% 25.62 ms +6.75% -3.32% -2.58%
listViewOpen 61.84 ms +5.34% -6.73% 63.1 ms +8.27% -7.83% -2%
inserterOpen 33.52 ms +15.27% -5.52% 34.11 ms +22.49% -10.32% -1.73%
inserterHover 9.68 ms +7.44% -2.58% 9.64 ms +8.82% -6.54% 0.41%
inserterSearch 7.45 ms +16.78% -11.41% 7.15 ms +5.17% -2.52% 4.2%
loadPatterns 512.23 ms +4.57% -2.06% 508.94 ms +2.53% -2.3% 0.65%
wpTotal 309.16 ms +7.82% -7.1% 321.93 ms +5.57% -9.16% -3.97%
wpMemoryUsage 14.81 MB +0% -0% 14.77 MB +0% -0% 0.25%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric 51afcb8 trunk % Change
serverResponse 284.44 ms +2.21% -0.98% 282.96 ms +4.68% -9.7% 0.52%
firstPaint 314.02 ms +7.58% -6.53% 290 ms +12.3% -6.63% 8.28%
domContentLoaded 593.32 ms +14.53% -3.01% 581.37 ms +1.71% -1.83% 2.06%
loaded 593.98 ms +14.53% -3.02% 582 ms +1.71% -1.84% 2.06%
firstContentfulPaint 338.57 ms +15.67% -3.21% 327.76 ms +2.91% -0.81% 3.3%
firstBlock 1784.99 ms +8.24% -1.52% 1766.33 ms +1.98% -1.23% 1.06%
type 14.84 ms +10.98% -8.22% 15.09 ms +5.96% -12.92% -1.66%
navigate 94.87 ms +5.04% -9.42% 91.49 ms +9.57% -5.49% 3.69%
loadPatterns 1058.15 ms +8.5% -15.4% 958.71 ms +22.28% -10.92% 10.37%
loadPages 952.8 ms +3.77% -1.26% 969.19 ms +0.52% -0.88% -1.69%
wpTotal 277.31 ms +2.26% -1.05% 275.4 ms +4.98% -9.8% 0.69%
wpMemoryUsage 12.82 MB +0% -0% 12.79 MB +0% -0% 0.25%
wpDbQueries 45 +0% -0% 45 +0% -0% 0%

54f810b Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

allows widgets to be moved between widget areas using the dropdown in the block toolbar in /test/e2e/specs/widgets/editing-widgets.spec.js, passed after 1 failed attempt.

does not select blocks in the canvas preview when editing from the sidebar in /test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator: getByRole('combobox', { name: 'Search or type URL' })
Expected: focused
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeFocused" getByRole('combobox', { name: 'Search or type URL' }) with timeout 5000ms
  - waiting for getByRole('combobox', { name: 'Search or type URL' })

    at LinkControl.useLinkControlSearch (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:416:47)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:179:21
should have keyboard navigable link UI popover in /test/e2e/specs/editor/blocks/image.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator: getByRole('combobox', { name: 'URL' })
Expected: focused
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeFocused" getByRole('combobox', { name: 'URL' }) with timeout 5000ms
  - waiting for getByRole('combobox', { name: 'URL' })

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:966:28
should select synced pattern in /test/e2e/specs/editor/various/writing-flow.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  locator('[name="editor-canvas"]').contentFrame().locator('[data-type="core/block"]')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" locator('[name="editor-canvas"]').contentFrame().locator('[data-type="core/block"]') with timeout 5000ms
  - waiting for locator('[name="editor-canvas"]').contentFrame().locator('[data-type="core/block"]')
    14 × locator resolved to <div tabindex="0" role="document" draggable="true" data-title="Pattern" data-type="core/block" data-is-drop-zone="true" aria-label="Block: Pattern" id="block-57d5427f-0b67-4545-a0ff-9a38d9a16e20" data-block="57d5427f-0b67-4545-a0ff-9a38d9a16e20" class="block-editor-block-list__block wp-block is-selected is-reusable block-library-block__reusable-block-container wp-block-block block-editor-block-list__layout">…</div>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/writing-flow.spec.js:1464:5

54f810b Run

Keep the small Button typography change from the original PR and use the current trunk styles for the rest of the component.
@ciampo ciampo changed the title Components: update Button to use more wpds tokens Components: Increase small Button font size Nov 19, 2026
@github-actions
github-actions Bot requested a review from aduth November 19, 2026 10:19
@jameskoster

Copy link
Copy Markdown
Contributor

I forget where exactly but I think small buttons are used in the block inspector or global styles. Could we include a list of current consumers to test?

@jasmussen

Copy link
Copy Markdown
Contributor

Unrelated, at some point I'd like to revisit how we treat stroke icons, with a proposal I made here. That could affect icon-sizing, and weight, for small buttons.

@ciampo

ciampo commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

I've added a "Gutenberg screens" section in the PR description with before/after screenshots

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design System Issues related to the system of combining components according to best practices. [Feature] Component System WordPress component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants