Skip to content

TT1 blocks: cleanup CSS - #28

Closed
MaggieCabrera wants to merge 4 commits into
trunkfrom
tt1-css-cleanup
Closed

TT1 blocks: cleanup CSS#28
MaggieCabrera wants to merge 4 commits into
trunkfrom
tt1-css-cleanup

Conversation

@MaggieCabrera

@MaggieCabrera MaggieCabrera commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

Closes #24

This PR is a WIP. We are aiming to remove most of (if not all) the CSS from the theme.

@MaggieCabrera
MaggieCabrera marked this pull request as draft March 30, 2023 09:11
@MaggieCabrera MaggieCabrera self-assigned this Mar 30, 2023
--------------------------------------------------------------*/

.wp-block-cover.is-style-twentytwentyone-border {
.is-style-twentytwentyone-border {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed so we don't lose the border on already inserted patterns with the old markup. I hope by the end of this PR we can move this to style.css

}

/*
* Alignment styles.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add the theme.json for the global padding on this issue

@carolinan

Copy link
Copy Markdown
Collaborator

Should we merge this and the theme.json update to one branch (I don't know how but I think it would be easier)

@MaggieCabrera

Copy link
Copy Markdown
Collaborator Author

Should we merge this and the theme.json update to one branch (I don't know how but I think it would be easier)

I don't, either. We could make one PR based on the other but I don't know how much we need to do that, this PR so far is not touching on theme.json, I was expecting the theme.json PR to be merged before this one anyway

@carolinan

Copy link
Copy Markdown
Collaborator

I'm finding it difficult to see how the theme.json changes affect the theme because that PR doesn't remove the CSS.

@MaggieCabrera

Copy link
Copy Markdown
Collaborator Author

I'm finding it difficult to see how the theme.json changes affect the theme because that PR doesn't remove the CSS.

I'm not working on this today, if you want you can cherry pick my commits to your PR and we can close this one

@MaggieCabrera

Copy link
Copy Markdown
Collaborator Author

Merged these changes inside #29 so we just work on that one branch. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TT1 blocks: Remove CSS that is no longer needed

2 participants