Repository navigation
Conversation
…ters A kind added through `wpai_workspace_proposal_kinds` was offered to the model and stored, but the transcript only drew cards for results from a hard-coded copy of the built-in kinds' propose abilities. The turn ended waiting on a card that never appeared. The page now passes Proposal_Store::proposal_abilities() to the client, and the transcript reads proposals from that list. The client copy stays as the fallback for page data without one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/ai-workspace #1382 +/- ##
====================================================
Coverage 86.81% 86.81%
Complexity 6330 6330
====================================================
Files 226 226
Lines 22901 22902 +1
====================================================
+ Hits 19882 19883 +1
Misses 3019 3019
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1004.
What
A proposal kind another plugin registers through
wpai_workspace_proposal_kindsnow gets its card in the AI Workspace.Before this, such a kind was offered to the model and its proposal was stored, but the transcript only looked for proposals in results from a hard-coded copy of the built-in kinds' propose abilities (
PROPOSAL_ABILITIESinutils/proposal.ts). The turn ended waiting on the person, and no card appeared. Found while integrating VIP Workflow'sworkflowkind (Automattic/vip-workflows#196).How
Admin_PagepassesProposal_Store::proposal_abilities()to the client asproposalAbilities. It's built from the kinds, so it includes filter-registered ones.Transcriptreads proposals from that list.PROPOSAL_ABILITIESstays as the fallback when the page data has none, andproposalAbilitiesFrom()keeps only non-empty strings.Proposal_StoreTest::test_client_proposal_abilities_match_the_serverstill guards the fallback against the built-in kinds.Testing
Admin_PageTest::test_page_data_lists_the_proposal_abilities,Admin_PageTest::test_page_data_lists_a_kind_another_plugin_registers.ai-workspace-proposal-abilities.spec.ts(new, 3 tests) andai-workspace-proposal-card.spec.ts, 38 passed.workflowkind on a local site, asking for an editorial workflow now shows the "Create 1 draft" card with the stages, and approving creates the sequence as a draft. Before this change the same turn showed no card.AI assistance: Yes. Tool(s): Claude Code (Claude Opus 5.5). Used for: diagnosing the missing card, writing the fix and tests, and drafting this description.
I've reviewed the changes, understand them and can explain them under review. They have all been tested locally.
🤖 Generated with Claude Code