SLOP-397: require edit token for clearNotification action (CSRF) - #9
Open
tosfos wants to merge 1 commit into
Open
SLOP-397: require edit token for clearNotification action (CSRF)#9tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
Special:PendingReviews cleared a watchlist notification timestamp on any GET carrying clearNotificationTitle/clearNotificationNS, with no token check — a forged cross-site link or image could silently mark the victim\x27s pages as reviewed. Require the user\x27s edit token and embed it in the buttons that generate these links.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Special:PendingReviewsperforms a state change on any GET request carryingclearNotificationTitle/clearNotificationNS:handleClearNotification()→PendingReview::clearByUserAndTitle()resets the victim'swl_notificationtimestamp, with no token check. A forged cross-site link or<img>tag silently marks the victim's pending reviews as reviewed.Fix:
handleClearNotification()now requires the user's edit token (matchEditToken), throwingPermissionsError('editmywatchlist')when absent/invalid.getClearNotificationButton()embeds the token in the generated links, so normal UI flow is unchanged.Verification
php -lclean on php:7.4-cli and php:8.2-cli.PermissionsErrorunder NEW; legit tokened request → write succeeds.Note: SLOP-384 covers the same pattern for the
unreviewparameter on Special:PageStatistics — fixed separately since it needs its own link-builder update in ReviewHandler::getTemplate().Closes SLOP-397.