SLOP-378: call fetchObject()/fetchRow() on result wrappers, not DB handles (removed in MW 1.39) - #8
Open
tosfos wants to merge 1 commit into
Open
SLOP-378: call fetchObject()/fetchRow() on result wrappers, not DB handles (removed in MW 1.39)#8tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
IDatabase::fetchObject() and IDatabase::fetchRow() were removed in MW 1.39; select()/query() return IResultWrapper which still exposes both. Calling them on the DB handle now fatals (Call to undefined method). Rewritten the 8 live call sites to invoke the methods on the result wrapper, matching every other site in the codebase.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDatabase::fetchObject()andIDatabase::fetchRow()were removed in MediaWiki 1.39;select()/query()return anIResultWrapperwhich still exposes both methods. Eight live call sites still invoked them through the DB handle ($dbr->fetchRow( $res ),$dbr->fetchObject( $result )), fataling withCall to undefined methodon MW 1.39:WatchAnalyticsUser.php:33includes/PendingReview.php:185,252includes/UserWatchesQuery.php:122includes/WatchAnalyticsParserFunctions.php:79,192specials/SpecialPageStatistics.php:266specials/SpecialWatchAnalytics.php:108All rewritten to
$res->fetchRow()/$result->fetchObject()— the same shape the other ~15 fetch sites in this codebase already use. One commented-out site updated for consistency.Verification
php -lclean on php:7.4-cli and php:8.2-cli for all 7 touched files.select()returning a result wrapper — OLD shape ($dbr->fetchRow($res)) fatals withCall to undefined method; NEW shape ($res->fetchRow()) iterates rows correctly.Closes SLOP-378.