SLOP-374: escape ?page= reflection in Special:PageStatistics (reflected XSS) - #6
Open
tosfos wants to merge 1 commit into
Open
SLOP-374: escape ?page= reflection in Special:PageStatistics (reflected XSS)#6tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…ed XSS) The not-a-page error message interpolated the raw request parameter into addHTML; escape it with htmlspecialchars(ENT_QUOTES).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Special:PageStatistics(viewable by all users) echoed the raw?page=request parameter into$wgOut->addHTML()when the requested title doesn't exist or isn't watchable:A link like
Special:PageStatistics?page=<img src=x onerror=alert(1)>executes attacker script in the wiki domain (classic reflected XSS). The fix escapes withhtmlspecialchars( $requestedPage, ENT_QUOTES )— the value still renders as text, but can no longer break out into markup.Verification
php -lclean on php:7.4-cli and php:8.2-cli.<img ...>markup; NEW output contains only<imgescaped form and zero raw tag openers.Closes SLOP-374.