SLOP-375: replace removed Title::isWatchable() (fatal on every page view on MW 1.38+) - #5
Open
tosfos wants to merge 1 commit into
Open
SLOP-375: replace removed Title::isWatchable() (fatal on every page view on MW 1.38+)#5tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…Watchable() Title::isWatchable() was removed in MW 1.38; calling it fatals the PageViewUpdates deferred update on every page view (ReviewHandler::setup) and breaks Special:PageStatistics. Adds ReviewHandler::isWatchable( Title ) helper delegating to MediaWikiServices NamespaceInfo::isWatchable( ns ) on 1.34+, with the old talk-page heuristic as pre-1.34 fallback.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Title::isWatchable()was removed in MediaWiki 1.38. Two call sites remained:includes/ReviewHandler.php:40(ReviewHandler::setup) — invoked from thePageViewUpdateshook, i.e. every page view by a logged-in user fatals the deferred update withCall to undefined method Title::isWatchable().specials/SpecialPageStatistics.php:38— fatals Special:PageStatistics.Adds a
ReviewHandler::isWatchable( Title )helper that delegates toMediaWikiServices::getInstance()->getNamespaceInfo()->isWatchable( $title->getNamespace() )(available since MW 1.34), falling back to the removed method's old talk-page heuristic on older branches. Both call sites now use the helper.Verification
php -lclean on php:7.4-cli and php:8.2-cli for both files.NamespaceInfo::isWatchablesemantics confirms correct verdicts for article/talk/user namespaces (watchable) vs Special/Media (not watchable).Closes SLOP-375.