SLOP-396/SLOP-382: harden forceGraph JSON encoding; replace removed wfMsgHTML - #2
Open
tosfos wants to merge 1 commit into
Open
SLOP-396/SLOP-382: harden forceGraph JSON encoding; replace removed wfMsgHTML#2tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…fMsgHTML Special:WatchAnalytics::forceGraph() now encodes the graph JSON with JSON_HEX_TAG|AMP|APOS|QUOT so usernames/titles embedded in the text/template script block cannot break out into markup regardless of runtime defaults; JSON.parse on the client decodes transparently. wfMsgHTML() (removed in MW 1.27) replaced with ->escaped(), identical semantics.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in
specials/SpecialWatchAnalytics.php:<script type='text/template'>via plainjson_encode(). Encoding now usesJSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS | JSON_HEX_QUOTso<,>,&, quotes are hex-escaped and the block cannot be terminated or polluted by payload content, independent of PHP build defaults. Client-sideJSON.parse()decodes the escapes transparently (verified round-trip), so rendering is unchanged for benign data.wfMsgHTML( 'listusers-noresult' )fatals on any modern MW when the user list is empty. Replaced with$this->msg( 'listusers-noresult' )->escaped()— byte-identical semantics (htmlspecialchars).Verification
php -lclean on php:7.4-cli and php:8.2-cli.</>; payload round-trips byte-identical throughjson_decode;->escaped()matches oldwfMsgHTMLsemantics./injson_encodeby default, which already mitigates the plain</script>case; the explicit flags make the guarantee unconditional and also neutralize raw</>from any source.Closes SLOP-396, SLOP-382.