SLOP-381: port WatchedItem::fromUserTitle to WatchedItemStore; fix ->current property bug - #13
Open
tosfos wants to merge 1 commit into
Open
SLOP-381: port WatchedItem::fromUserTitle to WatchedItemStore; fix ->current property bug#13tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…current WatchedItem::fromUserTitle()/isWatched()/addWatch() were removed in MW 1.31. Port clearByUserAndTitle() to WatchedItemStore:: resetNotificationTimestamp() and addCategoryToWatchlist.php to WatchedItemStore::isWatched()/addWatch(). Also fix $titleArray->current (undefined property, always null -> empty page names and broken addWatch targets) to $titleArray->current().
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WatchedItem::fromUserTitle(),WatchedItem::isWatched()andWatchedItem::addWatch()were removed in MediaWiki 1.31 (deprecated 1.27). Two live call paths fatal on any modern MW:includes/PendingReview.php::clearByUserAndTitle()— the clear-notification path of Special:PendingReviews fatals withClass 'WatchedItem' not found.maintenance/addCategoryToWatchlist.php— the script cannot run at all.Ports:
clearByUserAndTitle()→MediaWikiServices::getInstance()->getWatchedItemStore()->resetNotificationTimestamp( $user, $title )(same effect: nulls the notification timestamp).WatchedItemStore::isWatched( $user, $title )/addWatch( $user, $title ).Also fixes a second bug in the maintenance script:
$titleArray->currentis a property access on a TitleArray (an ArrayIterator subclass) — always null with a warning, producing empty page names and broken watch targets. Changed to the method call$titleArray->current().Verification
php -lclean on php:7.4-cli and php:8.2-cli for both files.fromUserTitlereferences; no remaining->currentproperty accesses without call parens in maintenance code.Closes SLOP-381.