SLOP-373: fix SQL injection in groupfilter/categoryfilter/ClearPendingReviews - #1
Open
tosfos wants to merge 1 commit into
Open
SLOP-373: fix SQL injection in groupfilter/categoryfilter/ClearPendingReviews#1tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…gReviews Replace raw string interpolation of user-controlled values into SQL join conditions and WHERE clauses with MediaWiki parameterized conditions (array conds -> quoted values, buildLike for prefix match, addQuotes for timestamps). Sites fixed: - UserWatchesQuery::getQueryInfo() groupfilter join (?groupfilter=) - WatchesQuery::setCategoryFilterQueryInfo() (?categoryfilter=) - SpecialClearPendingReviews::doSearchQuery() category/page/start/end
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three SQL injection sites where user-controlled values were interpolated verbatim into raw SQL strings (all inherited from upstream wikimedia/mediawiki-extensions-WatchAnalytics):
includes/UserWatchesQuery.php—$this->userGroupFilter(from public?groupfilter=on Special:WatchAnalytics) was spliced into theuser_groupsRIGHT JOIN condition inside double quotes. Payloadx" OR 1=1) UNION SELECT user_password FROM user-- -executed a full UNION breakout (verified live against MariaDB: returned password hashes from theusertable).includes/WatchesQuery.php::setCategoryFilterQueryInfo()— same pattern for?categoryfilter=againstcategorylinks.cl_to.specials/SpecialClearPendingReviews.php::doSearchQuery()—category,page,start, andendform fields were interpolated into WHERE clauses with single quotes (c.cl_to='$category',LIKE '$page%',< $end). Requires theclearreviewsright, but any holder could read/modify arbitrary data.Fix
Replace raw string interpolation with MediaWiki parameterized constructs that quote automatically:
[ 'w.wl_user = ug.ug_user', 'ug.ug_group' => $filter ]) → rendered viamakeList/addQuotes.$dbw->buildLike( $page, $dbw->anyString() )for the title prefix match.$dbw->addQuotes()for the start/end timestamp comparisons.Also null-coalesce missing
category/pageform fields (PHP 8 warning source).Verification
php -lclean on PHP 7.4-cli and 8.2-cli for all three files./tmp harness): old join condition executes the UNION payload returningbob,hashA,hashB; fixed query treats the payload as a literal group name and returns no breakout rows. Old ClearPendingReviews LIKE' OR 1='1matched every row; fixed version matches only the literal prefix.Closes SLOP-373.