Render explosion particles after the asteroid that spawned them dies (SLOP-451) - #2
Open
tosfos wants to merge 1 commit into
Open
Render explosion particles after the asteroid that spawned them dies (SLOP-451)#2tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
Explosion particles lived on each asteroid's own particle system and were only drawn via Asteroid.draw(). Since a destroyed asteroid is removed from the game state in the same tick as explode(), its explosion could never be seen - asteroids simply vanished when shot, despite the effect promised in the README. Destroyed asteroids now hand their still-alive particle systems to a game-level explosions list which keeps updating and drawing them until they fade out, and is cleared on restart. Fixes SLOP-451 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Asteroid.draw(), but a destroyed asteroid is removed from the game state in the same collision tick asexplode(). Result: the advertised explosion effect was dead code - asteroids just vanished when shot.explosionslist, which keeps updating and drawing it until all particles fade out (and clears on restart).Evidence
Verified empirically with a headless harness driving the real game classes (pygame-ce 2.5.8, Python 3.14):
Test plan
python -m py_compileon all modules