Fix ZeroDivisionError crash in Particle.update() (SLOP-450) - #1
Open
tosfos wants to merge 1 commit into
Open
Conversation
…ches 0 Once a particle's countdown hit 0, the fade computation divided by zero, crashing the game during normal play after asteroid explosions. Clamp alpha to 0 once the particle is expired, matching the pattern already used in particle.py. Fixes SLOP-450 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asteroids_game.pyParticle.update()divided by zero once a particle'slifetimecountdown reached 0, killing the whole game during normal play shortly after any asteroid explosion (explode()spawns particles with lifetimes of 20-40 frames).particle.py.Evidence
Verified empirically with a headless harness driving the actual class from this file (pygame-ce 2.5.8, Python 3.14):
ZeroDivisionError: division by zero.Fixes SLOP-450
Test plan
python -m py_compile asteroids_game.py