Exit nonzero when configured documents fail to generate - #2
Open
tosfos wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
compile_document() previously logged a warning and returned None for missing policies/modules and template errors, so main() reported success (exit 0) even when requested documents were not generated. Return success/failure from compile_document(), propagate it in main(), and sys.exit(1) if anything failed so CI/cron can detect broken output. Co-authored-by: Cursor <cursoragent@cursor.com>
tosfos
force-pushed
the
SLOP-448-exit-code-on-failure
branch
from
August 23, 2026 19:21
1bb3e44 to
4f45cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SLOP-448 (https://wikiteq.atlassian.net/browse/SLOP-448)
Summary
templates/generate.pylogged a warning and moved on when a configured policy directory, module file, or industry document was missing (or when template compilation/rendering failed), then still printed "Document generation complete" and exited 0 — so CI/cron/Make wrappers treated partially-generated or empty output as success.compile_document()now returnsTrue/False;main()aggregates the results and exits 1 with an explicit error message if any requested document could not be generated.Verification
masterfirst: config requesting a nonexistent policy + nonexistent module produced only warnings and exit 0.--validate-only: exit 0Audit context: org-wide audit of WikiTeq repositories.