load: import the shared loader where module-scope code can see it - #105
Merged
Merged
Conversation
An import inside main() is invisible to a module-scope function in the same file, and this bit twice in a row for the same reason: the conversion to pollard_load put each import at the FIRST use it found, which happened to be inside main(). pollard_abliterate NameError: text_layers -- raised from abliterate() pollard_probe NameError: text_layers -- raised from _linears() Both only when the helper was reached outside main(), so a CLI run could look fine while a library call died. Fixing the first instance and not the rest is what let the second one happen. Hoisted to module level in all ten tools that use it. pollard_flybrain stays lazy on purpose: pollard_load pulls in torch, and flybrain's optional-extra guard depends on torch not being required at import time. A test walks every pollard_*.py and fails on an indented `from pollard_load import`, because this is the third variant of one mistake and pattern-matching it by hand clearly does not work. 59/59 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An import inside main() is invisible to a module-scope function in the same file, and this bit twice in a row for the same reason: the conversion to pollard_load put each import at the FIRST use it found, which happened to be inside main().
pollard_abliterate NameError: text_layers -- raised from abliterate()
pollard_probe NameError: text_layers -- raised from _linears()
Both only when the helper was reached outside main(), so a CLI run could look fine while a library call died. Fixing the first instance and not the rest is what let the second one happen.
Hoisted to module level in all ten tools that use it. pollard_flybrain stays lazy on purpose: pollard_load pulls in torch, and flybrain's optional-extra guard depends on torch not being required at import time.
A test walks every pollard_*.py and fails on an indented
from pollard_load import, because this is the third variant of one mistake and pattern-matching it by hand clearly does not work.59/59 pass.