Skip to content

Assorted flag-lifting inaccuracies #21

Description

@xusheng6

Smaller flag issues found while reviewing the lifter, grouped since each is a line or two:

  • CPL uses flags="*", but it only sets H and N.
  • SCF / CCF do not touch H or N.
  • LD A,I / LD A,R set no flags; they should set S and Z, clear H and N, and copy IFF2 into P/V.
  • RETI / RETN do not model IFF1 <- IFF2.
  • CPI / CPD write only Z.
  • pv is mapped to OverflowFlagRole, so parity after logic ops is modelled as signed overflow (there is already a TODO about this in the source).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions