Serialize and deserialze sessions with email and userType - #804
Open
leonm1 wants to merge 1 commit into
Open
Conversation
leonm1
enabled auto-merge (squash)
March 4, 2021 12:01
gfting
approved these changes
Mar 4, 2021
gfting
left a comment
gfting
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522 by only serializing email and userType to DB.
I'm not sure if it'd be even better if we made it query all three hacker + organizer + sponsor models, as that way a log-out wouldn't be required when switching user types, but I feel this problem is better fixed in the user interface overhaul.