perf: stream s3 downloads via ranged GetObject request#429
Open
timkambic-ngen wants to merge 1 commit into
Open
perf: stream s3 downloads via ranged GetObject request#429timkambic-ngen wants to merge 1 commit into
timkambic-ngen wants to merge 1 commit into
Conversation
b-rowan
approved these changes
Jul 21, 2026
b-rowan
left a comment
b-rowan
left a comment
Member
There was a problem hiding this comment.
Looks good, I don't understand most of this, but seems fine. Untested ACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the S3 storage backend is used. When a device requests a download chunk(64kb) from goosebit. This chunk is requested from S3 and served to device. This is done via a single request
If device has bad connectivity this download can last longer than some proxies or s3 deployments have configured as a connection timeout. And in this case the connection is dropped. And request for next chunk will fail.
This PR changes the concept. Each chunk is requested separately via new request from S3 using ranged request. And then independently served to device.
This way it is almost impossible for s3 connection to timeout as it is very short lived.