Repository navigation
fix(frontend): spell Transferred correctly (EN-244) - #1295
Conversation
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
carddev81
left a comment
There was a problem hiding this comment.
Hey @CK-7vn, found a couple of things before it merges:
-
Please drop
docs/plans/EN-244-transferred-spelling/. Core doesn't keep adocs/plansfolder; this PR would be the first thing in it. The three files are working notes, mostly about the Programs repo. They also don't match the code: plan.md says 00004's Down reverses the change, but it's a no-op. The PR description and the Programs PR already cover the useful parts. -
Checklist. "Tested manually" and "All acceptance criteria verified" are ticked, but your own verification notes list the browser check of the Exports roster filter as UNVERIFIED. Please run it together with the Programs PR: transfer a resident, filter the roster report by Transferred, and check that the class outcomes show it. Then tick it. "Branch rebased" is ticked too, but the branch is on
b387158b, and main has moved since (#1294). Nothing conflicts; it just needs the rebase. -
What has to happen before EN-244 can close:
- This PR and unlocked-programs #6 are both merged.
- A platform PR moves staging's
programs.tagto the matching Programs build. This PR goes to staging by itself as soon as it merges, so do that platform PR at the same time. - The browser check passes on staging.
3509c8f to
8482a8b
Compare
carddev81
left a comment
There was a problem hiding this comment.
@CK-7vn, awesome job! Two small things:
- Browser check. "Tested manually" and "All acceptance criteria verified" are still ticked, but nothing shows the roster filter check was run. It needs the Programs side too, so the easiest place is staging, once both are merged. Untick those two boxes until then.
What has to happen before EN-244 can close:
- unlocked-programs #6 is approved and merged. It's failing govulncheck right now; it needs the Go 1.26.11 bump (in programs #12, or bump it in #6).
- This PR is merged. It goes to staging by itself, so merge it together with the next item.
- A platform PR moves staging's
programs.tag(stillsha-1e177e7) to the Programs build that has #6. - On staging: transfer a resident, filter the roster report by Transferred, and check that the class outcomes show the transfer.
- The Jira "Repo" line still says unlocked-core only. Please add unlocked-programs.
Pre-Submission PR Checklist
Description of the change
Spell "Transferred" correctly in the frontend: the EnrollmentStatus enum in attendance.ts, the Exports roster filter option and non-completing set, and the Programs tooltip. The roster filter now sends Transferred, matching the unlocked-programs change.
Release
Additional context