Skip to content

refactor: add .gitignore and use ucp-sdk python packages - #5

Closed
angryfoxx wants to merge 4 commits into
Universal-Commerce-Protocol:mainfrom
angryfoxx:rearrange-packages
Closed

refactor: add .gitignore and use ucp-sdk python packages#5
angryfoxx wants to merge 4 commits into
Universal-Commerce-Protocol:mainfrom
angryfoxx:rearrange-packages

Conversation

@angryfoxx

@angryfoxx angryfoxx commented Jan 12, 2026

Copy link
Copy Markdown

No description provided.

@angryfoxx
angryfoxx requested a review from a team January 12, 2026 12:14
@google-cla

google-cla Bot commented Jan 12, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

0x8000-0000
0x8000-0000 suggested changes Jan 14, 2026
View reviewed changes
Comment thread .gitignore
Comment thread a2a/README.md Outdated
Comment thread a2a/business_agent/pyproject.toml Outdated
Comment thread rest/python/client/flower_shop/pyproject.toml Outdated
Comment thread rest/python/server/.python-version Outdated
Comment thread rest/python/server/pyproject.toml Outdated
@angryfoxx
angryfoxx requested a review from 0x8000-0000 January 14, 2026 16:39
0x8000-0000
0x8000-0000 reviewed Jan 14, 2026
View reviewed changes
Comment thread rest/python/server/pyproject.toml Outdated
@angryfoxx
angryfoxx requested a review from 0x8000-0000 January 14, 2026 16:44
0x8000-0000
0x8000-0000 suggested changes Jan 14, 2026
View reviewed changes
Comment thread rest/python/server/.python-version Outdated

@0x8000-0000 0x8000-0000 Jan 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I was wrong to dismiss this change; I happened to test this code on another machine, and it failed with Python 3.14; Python 3.13 is required for some of the dependencies. Please add this back and then I will approve this change. But please note that we'll approve pull request #1 which has some substantial overlap with these changes so you'll have to rebase before final approval and merge.

@nearlyforget
nearlyforget requested a review from a team February 27, 2026 23:39
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days labels Jul 7, 2026
@damaz91

damaz91 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Backlog - closing this as samples already use ucp-sdk now. Thanks!

@damaz91 damaz91 closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@0x8000-0000 0x8000-0000 0x8000-0000 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:needs-triage Signal that the PR is ready for human triage status:stale Applied when PR is waiting for author response for 30 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@angryfoxx @damaz91 @0x8000-0000