fix: fixture dynamic fulfillment option ids - #93
Merged
carolinerg1 merged 1 commit intoAug 17, 2026
Merged
Conversation
damaz91
approved these changes
Aug 17, 2026
carolinerg1
approved these changes
Aug 17, 2026
carolinerg1
merged commit Aug 17, 2026
ba7d8ab
into
Universal-Commerce-Protocol:main
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_dynamic_fulfillmentexpected the option IDsexp-ship-usandexp-ship-intl. Those IDs belong to the reference sample, not the fulfillment contract, so a merchant that generated destination-specific options under different IDs failed conformance.Merged conformance #79 removed the same class of sample literals from the neighboring fulfillment tests and explicitly left this test for a follow-up because it needed a second-destination fixture.
Fix: move both destination/expected-option pairs into the optional
dynamic_fulfillmentfixture. The test now skips when the merchant declares no dynamic-fulfillment behavior, and otherwise checks the exact domestic and international cases supplied by that merchant. The flower-shop fixture preserves full reference-server coverage.Category (Required)
Related Issues
Follow-up to #79.
Checklist
generate_models.shunderpython_sdk(not applicable).Screenshots / Logs (if applicable)
N/A — the 10-test fulfillment module passes against the reference Python server; a custom fixture with merchant-specific IDs and the missing-fixture skip path were verified separately. Ruff, all pre-commit hooks, JSON validation, and
git diff --checkpass. The broader suite reaches the existing webhook response-model failures tracked by #88, outside these four files.