Skip to content

fix: accept in-band missing fulfillment errors #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damaz91 merged 2 commits into from
Aug 17, 2026
+6 −4
Merged

fix: accept in-band missing fulfillment errors #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57724c
fix: accept in-band missing fulfillment errors
FanouZeng-TT Aug 14, 2026
4575f0f
test: accept field_required in test_complete_without_fulfillment
damaz91 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions validation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ def test_complete_without_fulfillment(self) -> None:

Given a newly created checkout session without fulfillment details,
When a completion request is submitted,
Then the server should return a 400 Bad Request error.
Then the server either rejects with a 4xx describing the fulfillment
problem, or returns an in-band error message with code 'missing' or
'field_required'.
"""
response_json = self.create_checkout_session(select_fulfillment=False)
checkout_id = response_json["id"]
Expand All @@ -386,10 +388,10 @@ def test_complete_without_fulfillment(self) -> None:
headers=integration_test_utils.get_headers(),
)

self.assert_4xx_error(
self.assert_business_error(
response,
expected_status=400,
substring="Fulfillment address and option must be selected",
accepted_codes={"missing", "field_required"},
error_4xx_substring="fulfillment",
)

def test_structured_error_messages(self) -> None:
Expand Down
Loading