Skip to content

fix: InScenePlaced edge cases#4073

Merged
EmandM merged 10 commits into
develop-2.0.0from
fix/in-scene-placed-edge-cases
Jul 16, 2026
Merged

fix: InScenePlaced edge cases#4073
EmandM merged 10 commits into
develop-2.0.0from
fix/in-scene-placed-edge-cases

fix: serialize the scene placed field and fix DA scene migration (#4086)

bebbc3a
Select commit
Loading
Failed to load commit list.
Codecov GitHub.com / codecov/project succeeded Jul 16, 2026 in 1s

66.41% (+0.10%) compared to c538a0f

View this Pull Request on Codecov

66.41% (+0.10%) compared to c538a0f

Details

Codecov Report

Attention: Patch coverage is 41.62437% with 115 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
....netcode.gameobjects/Runtime/Core/NetworkObject.cs 40.47% 25 Missing ⚠️
...eobjects/Runtime/SceneManagement/SceneEventData.cs 0.00% 20 Missing ⚠️
...cts/Runtime/SceneManagement/NetworkSceneManager.cs 0.00% 18 Missing ⚠️
...gameobjects/Runtime/Configuration/NetworkPrefab.cs 14.28% 12 Missing ⚠️
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs 45.00% 11 Missing ⚠️
...tcode.gameobjects/Editor/InScenePlacedProcessor.cs 20.00% 8 Missing ⚠️
...time/SceneManagement/DefaultSceneManagerHandler.cs 0.00% 5 Missing ⚠️
...netcode.gameobjects/Editor/NetworkManagerHelper.cs 0.00% 4 Missing ⚠️
...gameobjects/Runtime/Components/NetworkTransform.cs 77.77% 4 Missing ⚠️
...cts/Runtime/Connection/NetworkConnectionManager.cs 55.55% 4 Missing ⚠️
... and 1 more
@@                Coverage Diff                @@
##           develop-2.0.0    #4073      +/-   ##
=================================================
+ Coverage          66.30%   66.41%   +0.10%     
=================================================
  Files                163      163              
  Lines              24927    24999      +72     
=================================================
+ Hits               16528    16603      +75     
+ Misses              8399     8396       -3     
Files with missing lines Coverage Δ
...ponents/Interpolator/BufferedLinearInterpolator.cs 86.31% <100.00%> (ø)
...meobjects/Runtime/Spawning/NetworkPrefabHandler.cs 61.26% <100.00%> (ø)
...netcode.gameobjects/Editor/NetworkManagerHelper.cs 48.36% <0.00%> (ø)
...gameobjects/Runtime/Components/NetworkTransform.cs 81.21% <77.77%> (ø)
...cts/Runtime/Connection/NetworkConnectionManager.cs 80.62% <55.55%> (ø)
....netcode.gameobjects/Runtime/Logging/NetworkLog.cs 73.01% <82.60%> (+19.01%) ⬆️
...time/SceneManagement/DefaultSceneManagerHandler.cs 20.86% <0.00%> (ø)
...tcode.gameobjects/Editor/InScenePlacedProcessor.cs 54.16% <20.00%> (-24.41%) ⬇️
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs 66.44% <45.00%> (+0.29%) ⬆️
...gameobjects/Runtime/Configuration/NetworkPrefab.cs 66.35% <14.28%> (-7.84%) ⬇️
... and 3 more

... and 4 files with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 66.41% <41.62%> (+0.10%) ⬆️

ℹ️ Need help interpreting these results?