Skip to content

Remove some outdated migrations - #2022

Open
hmpf wants to merge 5 commits into
mainfrom
remove-some-outdated-migrations
Open

Remove some outdated migrations#2022
hmpf wants to merge 5 commits into
mainfrom
remove-some-outdated-migrations

Conversation

@hmpf

@hmpf hmpf commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Scope and purpose

Removes any squashed migrations files.

After check out/install, in dev it is necessary to run

python manage.py migrate --prune argus_notificationprofile
python manage.py migrate --prune argus_incident
python manage.py migrate --prune argus_auth

to clean up the hidden migrations table. Smart to do it in production too.

How to test

  1. Migrate existing db, play around
  2. Run up a fresh copy of argus (using a different/empty database) to see if that is still possible, then see if tests are still green.

Testing with tox or github-actions does step 2 on every test-run.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • [ ] Added/amended tests for new/changed code
  • [ ] Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • [ ] If this results in changes in the UI: Added screenshots of the before and after
  • [ ] If this results in changes to the database model: Updated the ER diagram

@hmpf hmpf added the needs NOTES NOTES.md must be updated for release label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Test results

    8 files  1 792 suites   3m 31s ⏱️
1 005 tests 1 004 ✅ 1 💤 0 ❌
8 040 runs  8 032 ✅ 8 💤 0 ❌

Results for commit 71016aa.

♻️ This comment has been updated with latest results.

@hmpf hmpf self-assigned this Aug 5, 2026
@hmpf
hmpf force-pushed the remove-some-outdated-migrations branch from 7fda81a to 13bf91b Compare August 5, 2026 09:16
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.01%. Comparing base (36932bf) to head (71016aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         155      155           
  Lines        7321     7321           
=======================================
  Hits         6517     6517           
  Misses        804      804           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmpf
hmpf marked this pull request as ready for review August 5, 2026 09:33
@hmpf
hmpf requested a review from a team August 5, 2026 09:48
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@aleksfl aleksfl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not break anything in my testing scenarios. I would update / remove the skipped test class in migration_example.py that references the removed migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs NOTES NOTES.md must be updated for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants