Skip to content

Move get_relevant_address functionality to MediaPlugin base class - #2020

Merged
johannaengland merged 1 commit into
mainfrom
destinations/get-relevant-address
Aug 4, 2026
Merged

Move get_relevant_address functionality to MediaPlugin base class#2020
johannaengland merged 1 commit into
mainfrom
destinations/get-relevant-address

Conversation

@johannaengland

Copy link
Copy Markdown
Contributor

Scope and purpose

Similar to #2015. Copied from #936.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@johannaengland
johannaengland requested review from a team and hmpf August 3, 2026 14:06
@johannaengland johannaengland self-assigned this Aug 3, 2026
@johannaengland johannaengland added refactor nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) media-plugin destination All things DestinationConfig labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.01%. Comparing base (d58269a) to head (6ec77a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
- Coverage   89.02%   89.01%   -0.02%     
==========================================
  Files         155      155              
  Lines        7329     7321       -8     
==========================================
- Hits         6525     6517       -8     
  Misses        804      804              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Test results

    8 files  1 792 suites   3m 36s ⏱️
1 005 tests 1 004 ✅ 1 💤 0 ❌
8 040 runs  8 032 ✅ 8 💤 0 ❌

Results for commit 6ec77a6.

♻️ This comment has been updated with latest results.

Using the new MEDIA_SETTINGS_KEY we simplify the media
@johannaengland
johannaengland force-pushed the destinations/get-relevant-address branch from c6b7910 to 6ec77a6 Compare August 4, 2026 06:34
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@johannaengland
johannaengland merged commit 4f10fa6 into main Aug 4, 2026
19 checks passed
@johannaengland
johannaengland deleted the destinations/get-relevant-address branch August 4, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

destination All things DestinationConfig media-plugin nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants