Skip to content

Add constant MEDIA_SETTINGS_KEY to media - #2014

Merged
johannaengland merged 1 commit into
mainfrom
destinations/add-media-settings-key
Aug 3, 2026
Merged

Add constant MEDIA_SETTINGS_KEY to media#2014
johannaengland merged 1 commit into
mainfrom
destinations/add-media-settings-key

Conversation

@johannaengland

Copy link
Copy Markdown
Contributor

Scope and purpose

This will be used to simplify the plugins and to move more functionality to the base plugin. For now no changes in the functionality are done.

This is heavily inspired/copying some parts of #936.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@johannaengland
johannaengland requested review from a team and hmpf August 3, 2026 09:09
@johannaengland johannaengland self-assigned this Aug 3, 2026
@johannaengland johannaengland added refactor destination All things DestinationConfig nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.89%. Comparing base (af003a8) to head (493db59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         152      152           
  Lines        7283     7286    +3     
=======================================
+ Hits         6474     6477    +3     
  Misses        809      809           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Test results

    8 files  1 760 suites   2m 58s ⏱️
  980 tests   979 ✅ 1 💤 0 ❌
7 840 runs  7 832 ✅ 8 💤 0 ❌

Results for commit 493db59.

♻️ This comment has been updated with latest results.

@johannaengland
johannaengland force-pushed the destinations/add-media-settings-key branch from cf7a128 to c9c3ee5 Compare August 3, 2026 09:26
Comment thread docs/integrations/notifications/writing-notification-plugins.rst Outdated
This will be used to simplify the plugins
and to move more functionality to the base plugin
@johannaengland
johannaengland force-pushed the destinations/add-media-settings-key branch from 850bc7a to 493db59 Compare August 3, 2026 10:20
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@johannaengland
johannaengland merged commit 9d592c0 into main Aug 3, 2026
19 checks passed
@johannaengland
johannaengland deleted the destinations/add-media-settings-key branch August 3, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

destination All things DestinationConfig nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants