Add kiosk mode

[aleksfl]

Scope and purpose

Fixes #1938 .

Before:

After:

Adds some extra tests to pad the coverage.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

• Added a changelog fragment for towncrier
• Added/amended tests for new/changed code
• Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
• Linted/formatted the code with ruff and djLint, easiest by using pre-commit
• The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
• If this results in changes in the UI: Added screenshots of the before and after

[github-actions]

Test results

    8 files  1 800 suites   3m 28s ⏱️
  996 tests   995 ✅ 1 💤 0 ❌
7 968 runs  7 960 ✅ 8 💤 0 ❌

Results for commit 1b2d585.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (af2df43) to head (1b2d585).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   88.62%   89.50%   +0.87%     
==========================================
  Files         149      152       +3     
  Lines        7185     7296     +111     
==========================================
+ Hits         6368     6530     +162     
+ Misses        817      766      -51     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lunkwill42]

Kiosk mode sure doesn't look much different than just collapsing the filters, which was already possible - only detectable difference for me is that the footer line is removed and its filter summary moved to the filter row instead (and that isn't very space-saving - at worst, the footer would have just been pushed outside of the viewport in a long incident list)

I think I would prefer an even more minimal kiosk mode, perhaps pushing the "details" to the blue argus navbar instead. Likely the only thing needed in kiosk mode is to print the name of the selected filter, and the timestamp of the last update. But these are just opinions - I think this kiosk mode should be demoed to our NOC to get some actual user feedback.

One potential show-stopper in the details, thoug...

[hmpf]

Works, but I can only know that the kiosk-mode does something by hovering.

I have suggested adding "link", but we could also decide on never using btn-ghost.

There was a discussion at the accessibility group's latest meeting about invisible buttons. Common, but inaccessible. Ditto hiding the link underline. We have the much slopped #1985 which is about the same problem but in other parts of the dashboard.

Another possibility is having a two-pixel border around such buttons (also including the "special filters"-one, but that would have to be fixed in a different PR).

[hmpf]

Kiosk mode sure doesn't look much different than just collapsing the filters, which was already possible /../

/../ I think this kiosk mode should be demoed to our NOC to get some actual user feedback.

Agreed.

Didn't notice lunkwill's comments.

[hmpf]

Look/feel is approved.

[hmpf]

Follow-up: how to highlight links in general, what to do with buttons of little importance (like "special filters" in filter box), with updated style guide.

[aleksfl]

@hmpf @lunkwill42 Current version has been reworked to be even more minimal, I ran a live demo with the NOC and they preferred this version to their previous suggestion. Happy to get feedback on the code now, since the changes have been quite extensive to facilitate the rework.

[johannaengland]

Looks good, only nitpicks about tests and maybe more places to add link

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[hmpf]

Follow-up: All of these "if/if not kiosk_mode" in the templates when the opposite is nothing, it is tempting to break the contents out as either an independent fragment or as a partial in the same file.

The latter is available from Django 6.0+ so let's not do anything until we upgrade our minimum supported version.

[hmpf]

The header in the kiosk mode looks the same if:

1. No filters have been set
2. No named filter has been chosen
3. A filter has been set but not saved

It always says "Filter: None".

I would prefer that in case 1 it says "Unset" (or just remove the entirety of "Filter: None"), in case 2 it says "None" and in case 3 it says "Unsaved". If the total number of incidents is always shown in addition to "After filtering: " I would at least know if any filters are in place but altering what's after "Filter:" is more explicit.