[CURA-13266] Skin-support: No more infill-bridging over skin one layer lower. - #2363
Merged
Merged
Conversation
Skin supportwas still applied in some cases where there's only one layer of infill sandwiched between two layers of skin. Though this already should have worked; it turns out the bridging will 'fill in' the parts anyway. (Also even if that would have worked correctly, the normal infill wasn't applied to the 'sandwiched' area, so that woul've been empty.) This should now be fixed with this commit. CURA-13266
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit cda787e. ♻️ This comment has been updated with latest results. |
Erwan MATHIEU (wawanbreton)
left a comment
Erwan MATHIEU (wawanbreton)
left a comment
Contributor
There was a problem hiding this comment.
I was a bit concerned by the sandwiched wording at first, but it properly conveys its meaning 😃
Just one remark otherwise, to be discussed
done as part of CURA-13266
Erwan MATHIEU (wawanbreton)
approved these changes
Aug 19, 2026
Contributor
|
Before GregValiant (@GregValiant) I couldn't find the issue on the Cura side reports, if you encounter the issue during your sweeps, could you please link to this PR and close it with "Implemented for 5.14 release". Many thanks. |
Collaborator
|
I don't recall this one. I've been sweeping early issues to see if they were fixed/impacted since their submittal. I'll keep this in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skin support was still applied in some cases where there's only one layer of infill sandwiched between two layers of skin. Though this already should have worked; it turns out the bridging will 'fill in' the parts anyway. (Also even if that would have worked correctly, the normal infill wasn't applied to the 'sandwiched' area, so that would've been empty.) This should now be fixed with this commit.