CURA-13252 smooth tree support branches - #2360
Open
Erwan MATHIEU (wawanbreton) wants to merge 13 commits into
Open
CURA-13252 smooth tree support branches#2360Erwan MATHIEU (wawanbreton) wants to merge 13 commits into
Erwan MATHIEU (wawanbreton) wants to merge 13 commits into
Conversation
CURA-13252 I actually tried an implementation as suggested in the removed comment, but it ends up being slower because of the required bookkeeping and the impossibility of multi-threading it.
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit 8634794. ♻️ This comment has been updated with latest results. |
Remco Burema (rburema)
approved these changes
Aug 12, 2026
Erwan MATHIEU (wawanbreton)
left a comment
Erwan MATHIEU (wawanbreton)
left a comment
Contributor
Author
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 5cdf40b | Previous: ed0bd3e | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
1.7652989915507917 ns/iter |
1.117797545340744 ns/iter |
1.58 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: Jelle Spijker (@jellespijker) Erwan MATHIEU (@wawanbreton) Casper Lamboo (@casperlamboo) HellAholic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the tree support branches smoothing, as previously developed on the spike branch.
Smoothing is made starting from the current layer and going down only, so that branches separation does not generate position jumps.
Also the smoothing distance is capped to the distance to the top of the tree, so that smoothing decreases when moving up, and ends up ineffective on the top-most layers, that should keep their original shape to properly support the interface.
CURA-13252
Comes with Ultimaker/Cura#21749