Fix paint-on feature for WASM environment - #2358
Open
Casper Lamboo (casperlamboo) wants to merge 8 commits into
Open
Fix paint-on feature for WASM environment#2358Casper Lamboo (casperlamboo) wants to merge 8 commits into
Casper Lamboo (casperlamboo) wants to merge 8 commits into
Conversation
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit b0681d6. ♻️ This comment has been updated with latest results. |
Erwan MATHIEU (wawanbreton)
approved these changes
Aug 10, 2026
Previously _always_ inserting these small circles even if the path it replaces was printed anyway. Now this condition is re-inserted ensuring small features are _not_ printed twice. NP-1347
NP-1347
Remco Burema (rburema)
approved these changes
Aug 13, 2026
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
Went over the new changes together, so LGTM!
…olpaths vector is initialized and cleared appropriately.
… extremely long print estimations NP-1347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NP-1347