Skip to content

[CURA-12446] Added settings for a different number of walls in top-/bottom-most skin. - #20565

Closed
Remco Burema (rburema) wants to merge 13 commits into
mainfrom
CURA-12446_top_bottom_wall_count_new
Closed

[CURA-12446] Added settings for a different number of walls in top-/bottom-most skin.#20565
Remco Burema (rburema) wants to merge 13 commits into
mainfrom
CURA-12446_top_bottom_wall_count_new

Conversation

@rburema

@rburema Remco Burema (rburema) commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

See also engine PR: Ultimaker/CuraEngine#2227

@rburema Remco Burema (rburema) mentioned this pull request Apr 30, 2025
Closed
@rburema
Remco Burema (rburema) marked this pull request as draft April 30, 2025 14:28
@rburema

Remco Burema (rburema) commented Apr 30, 2025

Copy link
Copy Markdown
Member Author
  • (label) name may not be OK yet, '... Skin' could confuse people into thinking its multiple layers instead of top/bottom most (exposed to air)

@github-actions

github-actions Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit cfc8dd9.

♻️ This comment has been updated with latest results.

@rburema
Make the previously 'bottom' wall line count only apply to initial.
cc55ef7 
Otherwise the walls will adhere less well to the model, and while this is a nice visual change, structural integrity (especially when briding) is more important. Also this is what it already says in the ticket is needed, nothing really specified about non-top, non-initial layers.

part of CURA-12446
@rburema
Remco Burema (rburema) marked this pull request as ready for review May 6, 2025 09:55
@wawanbreton

Erwan MATHIEU (wawanbreton) commented May 7, 2025

Copy link
Copy Markdown
Contributor
  • (label) name may not be OK yet, '... Skin' could confuse people into thinking its multiple layers instead of top/bottom most (exposed to air)

You can have a look at flooring_extruder_nr and roofing_extruder_nr for the wording, which is slightly different, not sure it is better but at least it would be consistent.

wawanbreton
Erwan MATHIEU (wawanbreton) reviewed May 7, 2025
View reviewed changes
Comment thread resources/definitions/fdmprinter.def.json Outdated
Comment thread resources/definitions/fdmprinter.def.json Outdated
Copilot AI reviewed May 9, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • resources/definitions/fdmprinter.def.json: Language not supported

rburema
Remco Burema (rburema) commented Jun 17, 2025
View reviewed changes
Comment thread resources/definitions/fdmprinter.def.json Outdated
rburema
Remco Burema (rburema) commented Jun 17, 2025
View reviewed changes
Comment thread resources/definitions/fdmprinter.def.json
@wawanbreton
Erwan MATHIEU (wawanbreton) changed the base branch from main to 5.11 October 10, 2025 08:53
@github-actions

github-actions Bot commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Error Files:

  • 'File: resources/definitions/bambulab_a1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_a1mini.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_base.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_x1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1mini_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1mini_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_x1_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_x1_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_a1_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_a1mini_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_x1_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'

@wawanbreton
Erwan MATHIEU (wawanbreton) changed the base branch from 5.11 to main January 22, 2026 15:47
@wawanbreton Erwan MATHIEU (wawanbreton) mentioned this pull request Jun 1, 2026
Open
@rburema

Remco Burema (rburema) commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

superseded by #21634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wawanbreton Erwan MATHIEU (wawanbreton) wawanbreton approved these changes
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rburema @wawanbreton @HellAholic