alternative archetype move code (draft)#334
Draft
nnullcolumn wants to merge 1 commit into
Draft
Conversation
Author
|
so, a couple of things. i wasnt aware pr tests needed approval, but i ran them locally and all looks good. secondly, if the dst has a lot of ids the src doesn't that might mean unnecessary iteration (we should measure if this slows down bulk moves, or if we should only apply this to immediate updates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr is a draft, not intended to be merged as-is
wrote this out pretty quickly but the idea is to abuse sorted-ness of archetype types to find the ids which are present in both archetypes without hash lookups. i want to discuss the potential performance implications of this and also see if unit tests still pass. i've not put a lot of effort into this yet so i've marked this as a draft