Fix rule registry mutability issue with multiple language keys - #87
Merged
JohannesMeierSE merged 1 commit intoJul 24, 2025
Merged
Conversation
JohannesMeierSE
approved these changes
Jul 24, 2025
JohannesMeierSE
left a comment
JohannesMeierSE
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix!
Feel free to create even more PRs, if you find further issues!
JohannesMeierSE
pushed a commit
that referenced
this pull request
Aug 1, 2025
When registering rules with a `languageKey` array, the rule registry was storing the original array by reference. This led to issues when `removeRule` modified the array in place. This behavior caused problems in contexts where rules are removed and re-registered during initialization — such as in classes or functions —because the original `languageKey` array had already been altered. This PR resolves the issue by creating a shallow copy of the `languageKey` array during rule registration to ensure immutability and prevent side effects during rule lifecycle operations.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering rules with a
languageKeyarray, the rule registry was storing the original array by reference. This led to issues whenremoveRulemodified the array in place.This behavior caused problems in contexts where rules are removed and re-registered during initialization — such as in classes or functions — because the original
languageKeyarray had already been altered.This PR resolves the issue by creating a shallow copy of the
languageKeyarray during rule registration to ensure immutability and prevent side effects during rule lifecycle operations.