Remove undeclared dependency on langium in typir - #86
Merged
Conversation
JohannesMeierSE
approved these changes
Jul 24, 2025
JohannesMeierSE
left a comment
JohannesMeierSE
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for this finding!
JohannesMeierSE
pushed a commit
that referenced
this pull request
Aug 1, 2025
The `typir` package was relying on `assertUnreachable` from the `langium` package without declaring it as a dependency. Since Typir is intended to work as a standalone package, this implicit dependency could lead to issues. This PR replaces the `assertUnreachable` imports with a local implementation to ensure the package remains self-contained and does not rely on undeclared external modules.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
typirpackage was relying onassertUnreachablefrom thelangiumpackage without declaring it as a dependency. Since Typir is intended to work as a standalone package, this implicit dependency could lead to issues.This PR replaces the
assertUnreachableimports with a local implementation to ensure the package remains self-contained and does not rely on undeclared external modules.