Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/debugger-py.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: Python Debugger Image

on:
workflow_dispatch:
push:
branches:
- issue-690-debugger

env:
REGISTRY: ghcr.io
Expand All @@ -26,7 +23,7 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
Expand Down Expand Up @@ -56,7 +53,7 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}

- name: Attest
uses: actions/attest-build-provenance@v1
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
Expand Down
13 changes: 4 additions & 9 deletions .github/workflows/ghp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Volta
uses: volta-cli/action@v4

- name: Use pnpm
uses: pnpm/action-setup@v3
with:
version: 9
- name: mise-en-place
uses: jdx/mise-action@v2

- name: Install
shell: bash
Expand All @@ -51,7 +46,7 @@ jobs:
uses: actions/configure-pages@v5

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v4
with:
path: ./packages/examples/production/

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ls-clangd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
timeout-minutes: 150
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
labels: ${{ steps.meta_configure.outputs.labels }}

- name: Attest (configure)
uses: actions/attest-build-provenance@v1
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME_CONFIGURE }}
subject-digest: ${{ steps.push_configure.outputs.digest }}
Expand All @@ -81,7 +81,7 @@ jobs:
labels: ${{ steps.meta_build.outputs.labels }}

- name: Attest (build)
uses: actions/attest-build-provenance@v1
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME_BUILD }}
subject-digest: ${{ steps.push_build.outputs.digest }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ls-eclipsejdt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}

- name: Attest
uses: actions/attest-build-provenance@v1
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ls-groovy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}

- name: Attest
uses: actions/attest-build-provenance@v1
uses: actions/attest-build-provenance@v3
with:
subject-name: ${{ env.REGISTRY }}/${{ env.REPO_NAME }}/${{ env.CONTAINER_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Volta
uses: volta-cli/action@v4

- name: Use pnpm
uses: pnpm/action-setup@v3
with:
version: 9
- name: mise-en-place
uses: jdx/mise-action@v2

- name: Install
shell: bash
Expand Down
39 changes: 0 additions & 39 deletions .github/workflows/peer.yml

This file was deleted.

11 changes: 3 additions & 8 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Volta
uses: volta-cli/action@v4

- name: Use pnpm
uses: pnpm/action-setup@v3
with:
version: 9
- name: mise-en-place
uses: jdx/mise-action@v2

- name: Install
shell: bash
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,17 @@ Check find the [full compatibility table](https://github.com/TypeFox/monaco-lang

## Getting started

We recommend [mise-en-place](https://mise.jdx.dev/) to setup corrects version of required tools like `node` and `npm` (described [here](./docs/guides/troubleshooting.md#mise-en-place)). If you have `mise` installed use the optional isntruction below.

On your local machine you can prepare your dev environment as follows. At first it is advised to build everything. Locally, from a terminal do:

```bash
# clone the git repository
git clone https://github.com/TypeFox/monaco-languageclient.git
cd monaco-languageclient
# optional: if you have mise installed
mise upgrade
# install npm dependencies
npm i
# Cleans-up, compiles and builds everything
npm run build
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ If your dependency stack already contains a reference `monaco-editor` you must e
}
```

### Volta
### mise-en-place

There are [Volta](https://volta.sh/) instructions in the `package.json` files. When you have Volta available it will ensure the exactly specified `node` and `npm` versions are used.
We use [mise-en-place](https://mise.jdx.dev/) for tool management. In the past we used Volta, but unfourtunately is has become unmaintained. We will phase out volta instructions in the future. In the repository root you find [mise.toml](../../mise.toml) which specifies all tools required with the correct versions. Use `mise upgrade` to install the required tools.

### Bad Polyfills

Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Before installing Monaco Language Client, ensure you have:
We recommend using a Node.js version manager such as [nvm](https://github.com/nvm-sh/nvm) or [mise](https://mise.jdx.dev/).

> [!NOTE]
> Previously we have recommended using Volta to manage your Node.js versions, but as of late it is currently [unmaintained](https://github.com/volta-cli/volta), and their team recommends moving to an alternative solution, such as mise or nvm.
> Previously we have recommended using Volta to manage your Node.js versions, but as of late it is currently [unmaintained](https://github.com/volta-cli/volta). We now recommend to use [mise-en-place](https://mise.jdx.dev/). We will phase out volta instructions in the `monaco-languageclient` in the future.

You'll also need a project that you can use to install the `monaco-languageclient`. If you don't have one yet, you can get [started quickly by creating a new Vite project](https://vite.dev/guide/#scaffolding-your-first-vite-project) with React:

Expand Down
5 changes: 5 additions & 0 deletions mise.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[tools]
node = "24.13.0"
npm = "11.6.2"
pnpm = "10.28.0"
yarn = "4.12.0"
Loading