Repository navigation
refactor: Replace RCS rich content classifier with docs link; sync international capacity fix #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ee65215
feat: Add RCS rich content (twilio/card) classification and segmentation
thinkingserious f52e867
fix: Handle real Twilio API JSON format for RCS rich content
thinkingserious 52ceb48
refactor: Replace RCS rich content classifier with docs link; sync in…
thinkingserious b0b4422
Merge main into feature/rcs-rich-content
thinkingserious 67c9a7c
fix: Remove trailing newline in segmenter.ts (prettier lint)
thinkingserious f046e46
fix: Polish RCS info note wording per review feedback
thinkingserious 6105108
chore: Remove stale dist files for deleted RcsCardContent and RcsRich…
thinkingserious File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| export interface RcsCardAction { | ||
| type: string; | ||
| title?: string | null; | ||
| url?: string | null; | ||
| phone?: string | null; | ||
| webview_size?: string | null; | ||
| } | ||
| export interface RcsCardContent { | ||
| content_type: string; | ||
| title?: string | null; | ||
| body?: string | null; | ||
| subtitle?: string | null; | ||
| media?: string | string[] | null; | ||
| actions?: RcsCardAction[] | null; | ||
| orientation?: string | null; | ||
| thumbnailImageAlignment?: string | null; | ||
| height?: string | null; | ||
| } | ||
| export type RcsContentClassification = 'Rich' | 'Rich media'; | ||
| interface ClassificationResult { | ||
| classification: RcsContentClassification; | ||
| billableText: string; | ||
| } | ||
| /** | ||
| * Normalizes raw API JSON into the flat RcsCardContent format. | ||
| * | ||
| * The Twilio API returns rich content wrapped under a content-type key: | ||
| * { "twilio/card": { title: "...", body: null, ... } } | ||
| * | ||
| * This function detects that wrapper and extracts the inner object, | ||
| * setting `content_type` accordingly. If the input is already in the | ||
| * flat format (has a `content_type` string property), it is returned as-is. | ||
| */ | ||
| export declare const normalizeRcsContent: (raw: Record<string, unknown>) => RcsCardContent; | ||
| export declare const classifyRcsContent: (content: RcsCardContent) => ClassificationResult; | ||
| export {}; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ClassificationResult interface is not exported, but it is used as the return type of the exported function classifyRcsContent. This prevents consumers of this module from properly typing the return value. Export this interface to make it accessible to module consumers.