Skip to content

fix: Fix carousel click problem #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saglamburcu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Fix carousel click problem #98

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00042ea
fix: Fix carousel click problem
Feb 3, 2023
a6a130e
chore: Remove unnecessary style property
Feb 3, 2023
5774671
feat: Add triggerClickOn prop
Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/scrolling-carousel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,11 @@ export const ScrollingCarousel: FunctionComponent<SliderProps> = ({
const mouseUp = (_: MouseEvent) => {
setIsDown(false);
setShowArrow(showArrows());
slider.current!.classList.remove(styles.sliding);

@hasangenc0 hasangenc0 Feb 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you remove this line, the element that is targeted for this mouseUp event will ultimately trigger the onClick event and it will cause <a> elements to trigger a navigation while you still sliding. Check this feature if it's what you are trying to solve, and it can be implemented for this component too.

@saglamburcu saglamburcu Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the triggerClickOn prop as in carousel component. Could you review this again?

};

const mouseMove = (e: MouseEvent) => {
if (!isDown) return;
e.preventDefault();
slider.current!.classList.add(styles.sliding);
const eventPosition = e.pageX - slider.current!.offsetLeft;
const slide = eventPosition - position.startX;

Expand Down
4 changes: 0 additions & 4 deletions src/styles/slider/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,3 @@
.slider > * {
flex: 0 0 auto;
}

.sliding > * {
pointer-events: none;
}
2 changes: 0 additions & 2 deletions src/styles/slider/styles.module.css.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
export const sliderBase: string;
export const slider: string;
export const sliding: string;
interface Namespace {
sliderBase: string;
slider: string;
sliding: string;
}
declare const stylesModule: Namespace;
export default stylesModule;