Electon gui - #7
Open
Totto16 wants to merge 506 commits into
Open
Conversation
- make avi spans have multiple intervals, so that each nested chunk has its own range for the header - this is needed, to patch the language correctly, as the language offset is inside the header, and not the payload - also us spans, where start and end are used
- fix wrong interval calculation in AVIChunkSpan
- use newest spans, so that the bounded IO works as expected
- don't throw another exception, if we already have one, as e.g. throwing inside a r_ctx, that needs all bytes to be read, is not really helpfull, the error inside the reading likely will result in not all bytes being read and is more descriptive of what went wrong
…en, even if the box is already present
- some were introduces by new code, some by the io refactor
- can't read the truncated away meta box, need to read it before the truncation, store the needed values and then use them in the write phase
- those pass, so the custom mp4 tagger is ready 🎉
- refactor the interface, so that each writer is now named context - each one has a method to write the language, it may return false, which means this context doesn't support it - this makes the work with tags and the language separate,which it already is, but we can call it separately, and context, like mutagen which don't support language, can report that
…ary modules - import the heavy modules only in the subcommand function, they are actually used in
- use -X importtime to find biggest imports and make them smaller by refactoring the code or other means
- parse the string for the metadata key value, so that the tagger can write it
- implement "data" skipping for mkv "Cluster" elements
- also support multiple documents in the inspector
- everywhere we use it as result type, use the actual Result type instead
- use is Check for the global "singleton" instance rather tha a type check
- improve comparsion and error out, when comparing a FancyEq class with something, it can't be compared against
- use key in dct instead of the has function call
- use the class name too, so that the hash of the element itself isn't the same as the one from classes, that juts wrap that element - use proper hash_list function
… end and start detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.