static anaylsis results: shapebase - #1801
Merged
Areloch merged 2 commits intoAug 6, 2026
Merged
Conversation
if( !mDataBlock->debris )
{
mDataBlock->debris = new DebrisData;
-This was spinning up a new default debris per datablock at blowup usage time. so just referenced a static one.
-Forgot to clone the mAIControllData for the copy constructor, leading to unassigned behaviour.
-Sim::findObject( debrisID, debris ); doesn't need called twice bck to back
-Neither does updateMass();
-Make sure there *is* a mControllingObject before we call mControllingObject->mMount.object
-Make sure there is a mShapeInstance in all variants of ShapeBase::getNodeTransform
-Likewise with getTargetName(index);
-Be consistent with the return for getLastClipName()
-Properly clean up the mTypeMask if you try to assign an AIController and it fails. mTypeMask |= ~AIObjectType; actually flips everything *but* that one on.
the proper formulation is mTypeMask &= ~AIObjectType;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if( !mDataBlock->debris )
{
mDataBlock->debris = new DebrisData;
-This was spinning up a new default debris per datablock at blowup usage time. so just referenced a static one.
-Forgot to clone the mAIControllData for the copy constructor, leading to unassigned behaviour.
-Sim::findObject( debrisID, debris ); doesn't need called twice bck to back -Neither does updateMass();
-Make sure there is a mControllingObject before we call mControllingObject->mMount.object
-Make sure there is a mShapeInstance in all variants of ShapeBase::getNodeTransform -Likewise with getTargetName(index);
-Be consistent with the return for getLastClipName()
-Properly clean up the mTypeMask if you try to assign an AIController and it fails. mTypeMask |= ~AIObjectType; actually flips everything but that one on.
the proper formulation is mTypeMask &= ~AIObjectType;